1492046 - get rid of nsIDOMXULLabeledControlElement

Status: RESOLVED FIXED

(Core :: XUL, task, P5)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

depends on bug 1491210

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9009849 [details] [diff] [review]
patch

(I wonder why all this XUL interface removal right now)

Comment 2

[ExE Boss]

I’d recommend submitting patches using Phabricator, as it makes reviewing and landing them easier.
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

(Also, Splinter (the subsystem used for reviewing patches submitted directly to BMO) is deprecated)
https://groups.google.com/d/msg/firefox-dev/K4pYO-mtGBY/5UjFKxp7CAAJ

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(Phabricator does not make reviewing easier.)

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(And I never use sṕlinter on bugzilla. Just the 'details' link.)

Comment 5

[alexander :surkov (:asurkov)]

(In reply to Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) from comment #1)
> Comment on attachment 9009849 [details] [diff] [review]
> patch
> 
> (I wonder why all this XUL interface removal right now)

it's part of deXBLization project, where XUL elements either should be reimplemented as custom elements or moved to c++ or removed. Also there's no way currently to make a custom element to implement XUL interface (bug 1478372), thus they are removed when it's possible to ublock/simplify deXBLization.

(In reply to Olli Pettay [:smaug] (r- if the bug doesn't explain what the change(s) are about.) from comment #3)
> (Phabricator does not make reviewing easier.)

I also lean towards to old-style reviews, phabricator feels ok but overcomplicated

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aee03f432203
get rid of nsIDOMXULLabeledControlElement, r=smaug

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/aee03f432203