Closed Bug 1493397 (dav1d) Opened 6 years ago Closed 2 years ago

Switch AV1 implementation to dav1d

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Tracking Status
firefox64 --- affected

People

(Reporter: TD-Linux, Unassigned)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [media-feature] [av1])

gotta go fast
Blocks: 1493400
No longer blocks: 1493400
Depends on: 1493400
Blocks: AV1
Priority: -- → P2
Blocks: 1494493
External issues in dav1d that need to be solved before it can be the default decoder:

Missing features: https://code.videolan.org/videolan/dav1d/issues/34

Speed vs. libaom: https://code.videolan.org/videolan/dav1d/issues/15
dav1d is fast and covers all the spec:
http://www.jbkempf.com/blog/post/2018/dav1d-toward-the-first-release
Depends on: 1511223
Depends on: 1511224
Depends on: 1509453
Alias: dav1d
Depends on: 1516235
Depends on: 1515933
Depends on: 1521062
Blocks: 1533092

Is there a timetable for importing the new dav1d 0.2.0 release?

We're actually on dav1d git at the moment. But yeah we can do an update again, maybe to 0.2.1 that's about to be released. https://bugzilla.mozilla.org/show_bug.cgi?id=1533559

Depends on: 1533742
Depends on: 1535038
Depends on: 1536070

Currently dav1d uses only 1 tilethread in Firefox, making it painfully slow. It should at least use 2, and on systems with 8 or more logical processors 4.

Could you open a new bug about it and CC me? I will take care next.

(In reply to Alex Chronopoulos [:achronop] from comment #6)

Could you open a new bug about it and CC me? I will take care next.

Thanks! https://bugzilla.mozilla.org/show_bug.cgi?id=1536783

Depends on: 1536783

Can we build Firefox with system dav1d?

(In reply to Robert-André Mauchin from comment #8)

Can we build Firefox with system dav1d?

define system dav1d.

(In reply to Robert-André Mauchin from comment #8)

Can we build Firefox with system dav1d?

Starting from release 68 dav1d is the default av1 decoder for Linux, Windows and OSX, if that's what you mean.

If you're referring to something like --with-system-libvpx, the answer is currently no. Patches welcome, though it might be wise to wait for dav1d 1.0 first.

(In reply to Thomas Daede [:TD-Linux] from comment #11)

If you're referring to something like --with-system-libvpx, the answer is currently no. Patches welcome, though it might be wise to wait for dav1d 1.0 first.

I don't think we will ever want to support this.
Controlling what we use is much easier when it's code we ship.

Certainly don't want to have to duplicate work we need to do to support system ffmpeg for something like dav1d.

(In reply to Thomas Daede [:TD-Linux] from comment #11)

If you're referring to something like --with-system-libvpx, the answer is currently no. Patches welcome, though it might be wise to wait for dav1d 1.0 first.

That's what I mean indeed.

All the bugs that this depends on have closed, do you think we can close this one? If not can we make it depend on the corresponding bugs? Thanks!

Flags: needinfo?(tdaede)

Is there a bug for dav1d android? I can't find one.

Flags: needinfo?(tdaede)

Hmm I cannot find also a dav1d specific bug, there is one for AV1 in general Bug 1550568, at this point we can safely assume that if we enable AV1 in Android it will be dav1d. Will already build everything for arm.

Priority: P2 → P3
Whiteboard: [media-feature] [av1]
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.