Closed
Bug 1493695
Opened 6 years ago
Closed 6 years ago
[remote-dbg-next] Extract renderField method to dedicated component
Categories
(DevTools :: about:debugging, enhancement, P1)
DevTools
about:debugging
Tracking
(firefox65 fixed)
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: jdescottes, Assigned: ladybenko)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
As discussed while reviewing l10n changes, having a dedicated component instead of the renderField method would enable us to use fluent's Localized component rather than abusing withLocalization::getString. https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/devtools/client/aboutdebugging-new/src/components/debugtarget/ExtensionDetail.js#21 https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/devtools/client/aboutdebugging-new/src/components/debugtarget/WorkerDetail.js#33 With such a component we could rewrite the localization as Localized( { id: "about-debugging-something-field", attrs: { name: true, title: true } }, Field( { key: "something" name: "Fallback name", title: "Fallback title" }, content ) )
Reporter | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → balbeza
Status: NEW → ASSIGNED
Updated•6 years ago
|
Priority: P3 → P1
Assignee | ||
Comment 1•6 years ago
|
||
Pushed by balbeza@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9948f43917b0 Extract renderField method to dedicated component. r=jdescottes,daisuke
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9948f43917b0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•