Closed
Bug 1494994
Opened 6 years ago
Closed 6 years ago
Crash in mozilla::recordreplay::RR_CGBitmapContextCreateWithData
Categories
(Core Graveyard :: Web Replay, defect)
Tracking
(firefox-esr60 unaffected, firefox62 unaffected, firefox63 unaffected, firefox64 fixed)
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | --- | unaffected |
firefox64 | --- | fixed |
People
(Reporter: marcia, Assigned: bhackett1024)
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
576 bytes,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-327a44be-6831-4137-a242-3cd490180927. ============================================================= Although this appears to be a single installation crashing twice, I thought it was interesting since it also had webrender stuff in the stack. Top 10 frames of crashing thread: 0 XUL mozilla::recordreplay::RR_CGBitmapContextCreateWithData toolkit/recordreplay/ProcessRedirectDarwin.cpp:2195 1 libate.dylib EncodeASTC_4x4_RGBA_SSE4_1 2 XUL webrender::platform::macos::font::FontContext::new third_party/rust/core-graphics/src/context.rs:97 3 XUL webrender::renderer::Renderer::new gfx/webrender/src/glyph_rasterizer/mod.rs:560 4 XUL wr_window_new gfx/webrender_bindings/src/bindings.rs:975 5 XUL mozilla::wr::NewRenderer::Run gfx/webrender_bindings/WebRenderAPI.cpp:74 6 XUL mozilla::wr::RenderThread::RunEvent gfx/webrender_bindings/RenderThread.cpp:319 7 XUL mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void xpcom/threads/nsThreadUtils.h:1178 8 XUL MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:451 9 XUL base::MessagePumpDefault::Run ipc/chromium/src/base/message_pump_default.cc:38 =============================================================
Assignee | ||
Comment 1•6 years ago
|
||
The attached patch force-disables WebRender in recording/replaying processes. For now we only support the basic compositor / rendering paths when recording/replaying. This shouldn't affect any WebRender related IPC as WebRender will still be turned on in the middleman process, which is responsible for sending graphics rendered by the tab up to the UI process.
Assignee: nobody → bhackett1024
Attachment #9015132 -
Flags: review?(nical.bugzilla)
Comment 2•6 years ago
|
||
Comment on attachment 9015132 [details] [diff] [review] patch Review of attachment 9015132 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/thebes/gfxPlatform.cpp @@ +791,5 @@ > gfxVars::SetGREDirectory(nsString(path)); > } > + > + if (recordreplay::IsRecordingOrReplaying()) { > + gfxVars::SetUseWebRender(false); I'd prefer this to be in gfxPlatform::InitWebRenderConfig .
Attachment #9015132 -
Flags: review?(nical.bugzilla) → review+
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d85e5fb4421c Disable WebRender when recording/replaying, r=nical.
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d85e5fb4421c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Updated•6 years ago
|
status-firefox62:
--- → unaffected
status-firefox-esr60:
--- → unaffected
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•