149593 - Completion Date for each Bug

Status: RESOLVED DUPLICATE of bug 103636

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Salmaan Shikari]

This is my first posting.  (I have made the changes on my 2.14.1 version of 
Bugzilla and they are working)

This enhancement requires changes in the following files:
show_bug.cgi
query.cgi
post_bug.cgi
long_list.cgi
globals.pl
enter_bug.cgi
colchange.cgi
buglist.cgi
bug_form.pl
CGI.pl
process_bug.cgi
-------------------------------
I suggest that Bugzilla include the option to enter a Completion Date field for 
every bug.

1. The Completion Date should be set by the reporter.
2. The Completion Date should only be changed by the bug's component owner.
3. The addition of this date will require a new field "completion_date" added
to the "bugs" table.
4. Show the Completion date in the Query Results page, Long Format and normal 
view when editing a bug.
5. Allow user to sort query results by completion date.

Comment 1

[Salmaan Shikari]

Attachment: show_bug.cgi with modifications for completion date

The changes made to this file implement the completion date enhancement.

Comment 2

[Salmaan Shikari]

Attachment: query.cgi with modifications for completion date

query.cgi with modifications for completion date

Comment 3

[Salmaan Shikari]

Attachment: post_bug.cgi with modifications for completion date

post_bug.cgi with modifications for completion date

Comment 4

[Salmaan Shikari]

Attachment: long_list.cgi with modifications for completion date

long_list.cgi with modifications for completion date

Comment 5

[Salmaan Shikari]

Attachment: globals.pl with modifications for completion date

globals.pl with modifications for completion date

Comment 6

[Salmaan Shikari]

Attachment: globals.pl with modifications for completion date

globals.pl with modifications for completion date

Comment 7

[Salmaan Shikari]

Attachment: col_change.cgi with modifications for completion date

col_change.cgi with modifications for completion date

Comment 8

[Salmaan Shikari]

Attachment: buglist.cgi with modifications for completion date

buglist.cgi with modifications for completion date

Comment 9

[Salmaan Shikari]

Attachment: bug_form.pl with modifications for completion date

bug_form.pl with modifications for completion date

Comment 10

[Salmaan Shikari]

Attachment: CGI.pl with modifications for completion date

CGI.pl with modifications for completion date

Comment 11

[Salmaan Shikari]

Attachment: process_bug.cgi with modifications for completion date

process_bug.cgi with modifications for completion date

Comment 12

[Dave Miller [:justdave]]

Salmaan: Can you make diffs with diff -u of the original files against your
changes and upload that instead of the entire files?

reviewing entire files is very difficult for what is likely small changes to
many of these files.

Comment 13

[Salmaan Shikari]

Attachment: diff -u bug_form.pl (original) bug_form.pl (with changes)

diff -u bug_form.pl (original) bug_form.pl (with changes)

Comment 14

[Salmaan Shikari]

Attachment: diff -u buglist.cgi (original) buglist.cgi (with changes)

diff -u buglist.cgi (original) buglist.cgi (with changes)

Comment 15

[Salmaan Shikari]

Attachment: diff -u CGI.pl (original) CGI.pl (with changes)

diff -u CGI.pl (original) CGI.pl (with changes)

Comment 16

[Salmaan Shikari]

Attachment: diff -u colchange.cgi (original) colchange.cgi (with changes)

diff -u colchange.cgi (original) colchange.cgi (with changes)

Comment 17

[Salmaan Shikari]

Attachment: diff -u enter_bug.cgi (original) enter_bug.cgi (with changes)

diff -u enter_bug.cgi (original) enter_bug.cgi (with changes)

Comment 18

[Salmaan Shikari]

Attachment: diff -u globals.pl (original) globals.pl (with changes)

diff -u globals.pl (original) globals.pl (with changes)

Comment 19

[Salmaan Shikari]

Attachment: diff -u long_list.cgi (original) long_list.cgi (with changes)

diff -u long_list.cgi (original) long_list.cgi (with changes)

Comment 20

[Salmaan Shikari]

Attachment: diff -u post_bug.cgi (original) post_bug.cgi (with changes)

diff -u post_bug.cgi (original) post_bug.cgi (with changes)

Comment 21

[Salmaan Shikari]

Attachment: diff -u process_bug.cgi (original) process_bug.cgi (with changes)

diff -u process_bug.cgi (original) process_bug.cgi (with changes)

Comment 22

[Salmaan Shikari]

Attachment: diff -u query.cgi (original) query.cgi (with changes)

diff -u query.cgi (original) query.cgi (with changes)

Comment 23

[Salmaan Shikari]

Attachment: diff -u show_bug.cgi (original) show_bug.cgi (with changes)

diff -u show_bug.cgi (original) show_bug.cgi (with changes)

Comment 24

[Jouni Heikniemi]

Salmaan,

this cannot be reviewed like this, sorry. Here are some comments which could
help you further:

It's quite straining to review and apply a zillion-file patch set - just diff -u
all the modifications into a single patch file. You don't have to attach that
many files and we can only download one.

Your version management system has added some comments to all the files. We
don't want these comments into the bugzilla trunk code. Additionally, the
comments contain a copyright statement. Please understand that unless the patch
is released under MPL, we cannot use it. There is already a copyright heading in
the file; another is not needed.

The patch is against Bugzilla version 2.14.1, but unfortunately most of the
output code has been rewritten and templatized since then - we need patches for
the current codebase (2.17-trunk). 

If you need a schema change (that new field in the bugs table), you also need to
alter checksetup.pl.

Also note that we have a custom fields implementation coming up; check out bug 
91037. Slightly similar is also bug 24789, and bug 62370 is doing the same thing
from a bit different angle. Would some of these be of any assistance?

Please check out the Bugzilla hacking manuals from www.bugzilla.org, section
"How can you help". They will give you some ideas about how to push this forward.

Comment 25

[Joel Peshkin]

*** Bug 189762 has been marked as a duplicate of this bug. ***

Comment 26

[Jeff Hedlund]

Is this not a dup of bug 103636 ?

Comment 27

[Christian Reis]

Technically, maybe, but in practical terms, yes.

*** This bug has been marked as a duplicate of 103636 ***