Closed
Bug 1496324
Opened 6 years ago
Closed 6 years ago
Fix TransactionId handling in WebRenderLayerManager::EndEmptyTransaction()
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.64 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
The EndEmptyTransaction() does not get TransactionId by calling nsRefreshDriver::GetTransactionId() when transaction is not necessary. But it seems not good. In this case, it seems necessary to call the GetTransactionId() and then need to call nsRefreshDriver::RevokeTransactionId() to trigger next paint.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=203304764&revision=43f3893f7aca0c5671f99cc73970f0ec45ab636d Intermittent failure of Bug 1489327 seemed to be addressed.
|
|
Assignee | |
Comment 2•6 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #1) > https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=203304764&revision=43f3893f7aca0c5671f99cc73970f0ec45ab636d > > Intermittent failure of Bug 1489327 seemed to be addressed. Though, failure of Bug 1490117 still exists.
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 4•6 years ago
|
||
Attachment #9014286 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•6 years ago
|
||
ClientLayerManager also revoke TransactionId when transaction is not forwarded. https://dxr.mozilla.org/mozilla-central/source/gfx/layers/client/ClientLayerManager.cpp#749
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9014287 -
Flags: review?(matt.woodrow)
|
||
Updated•6 years ago
|
Attachment #9014287 -
Flags: review?(matt.woodrow) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1b41309fe5d6 Revoke TransactionId when transaction is not forwarded r=mattwoodrow
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1b41309fe5d6
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•