1496827 - Remove the "notification" binding

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P1)

Description

[Brian Grinstead [:bgrins]]

+++ This bug was initially created as a clone of Bug #1471403 +++

We had some discussion about this at https://mozilla.logbot.info/fx-team/20181005#c15423019, so figured I'd get a bug on file for it. This would help make conversion to Fluent possible for notification.

This needs more investigation, but if the notifications are only ever created from within the notificationbox or at least a limited set of places it's possible we could build the entire DOM up directly under that node instead of slotting in child nodes into the [anonid="details"] element: https://searchfox.org/mozilla-central/rev/807a37c670c093b6e5201841a7c5315ba67ba8d5/toolkit/content/widgets/notification.xml#397.

We could do that either with a Custom Element (which would allow us to translate the properties/methods as in https://github.com/bgrins/xbl-analysis/blob/gh-pages/elements/generated/Notification.js), or move all the logic up into notificationbox.

Comment 1

[:Paolo Amadini]

Attachment: Bug 1496827 - Remove the "notification" binding. r=bgrins

Comment 2

[:Paolo Amadini]

We may still have to update tests or production code that customizes the notifications, running a tryserver build here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5d54ed862b50078e43382df9244f0af3ed7fc93

Comment 3

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=43da8a1c1cae65d34c0529fd99f26590b964a236

Comment 4

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd3fc09b59834be0f7391926366704a514382c96

Comment 5

[Brian Grinstead [:bgrins]]

Heads up that more notification changes are incoming (this is follow on to the work at bug 1471403). This is a Custom Element conversion so that part should work straight away, but a number of tests are needing to be updated (things that dig into anon content, some property accesses switching to attribute lookups, etc). See https://phabricator.services.mozilla.com/D11650.

Comment 6

[Jorg K (CEST = GMT+2)]

Apparently we've already forked the binding and will de-XBL it later. Magnus, is anything required here?

Comment 7

[Brian Grinstead [:bgrins]]

You'll probably need to rename the XBL'ed element from <notification> to something else so that you don't end up with both XBL and a Custom Element attached to it after this bug lands.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91320b1c87ce
Remove the "notification" binding. r=bgrins

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/91320b1c87ce