1497215 - The browser crashes during the payment process if the " ; " punctuation mark is used in fields

Status: VERIFIED FIXED

(Core :: DOM: Web Payments, defect, P1)

Description

[Timea Cernea [:tbabos][inactive]]

[Affected versions]: 
Nightly 64.0a1 (2018-10-08)

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS 10.13, Ubuntu 16.04.

[Preconditions]:
1. Set the pref dom.payments.request.enabled to "true";
2. Make sure you have at least one Shipping Address and one Credit Card saved in your browser.

[Steps to reproduce]:
1. Go to "https://rsolomakhin.github.io/pr/us/" and click on "Buy"
2. Add or Edit a shipping address
3. Fill in any field with the " ; " punctuation mark 
4. Click on the "Pay" button on the Order Summary screen


[Expected result]:
The payment widget should be closed and the response displayed correctly.

[Actual result]:
The browser crashes. 

[Note]:
Tried out all the other basic punctuation marks and symbols on the keyboard, so far only " ; " seems to crash the browser. 

The crash can NOT be reproduced on Windows 7 x64.

Comment 2

[Matthew N. [:MattN]]

Great find! I think this is due to the IPC serialization using semicolons (IIRC).

Comment 3

[Eden Chuang[:edenchuang]]

Attachment: Define a new IPC structure for response data

I post the patch on the wrong bug and get the r+ 

https://bugzilla.mozilla.org/show_bug.cgi?id=1497219#c4

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa6b7a70f2db
Refactor the IPC structure for PaymentResponse.details r=baku

Comment 5

[Eliza Balazs [:ebalazs_]]

Backed out changeset fa6b7a70f2db (Bug 1497215) for xpcshell failures in browser/components/payments/test/unit/test_response_creation.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=fa6b7a70f2db81835c314543031fb6ce251fafce&selectedJob=206940166

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=206940166&repo=mozilla-inbound&lineNumber=7621

Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=dedd03c893c8cfa5a721b0a04cf5b26cee98db4b

This also caused a bc perma failure: https://treeherder.mozilla.org/logviewer.html#?job_id=206940146&repo=mozilla-inbound&lineNumber=11323

Comment 6

[Eliza Balazs [:ebalazs_]]

Please also see this perma bc LeakSanitizer failure: https://treeherder.mozilla.org/logviewer.html#?job_id=206957723&repo=mozilla-inbound

Comment 7

[Eden Chuang[:edenchuang]]

Attachment: Define a new IPC structure for response data

https://treeherder.mozilla.org/#/jobs?repo=try&revision=56b5730bf34025a1720e5e00c82cff68a0073c7e&selectedJob=207220698

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8238a4eeda86
Refactor the IPC structure for PaymentResponse.details r=baku

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8238a4eeda86

Comment 10

[Andrei Ciure[:aciure]]

Backed out changeset 8238a4eeda86 (bug 1497215) for runing a payment test before the leak detection

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=207259075&revision=8238a4eeda863b0a947afef38dd6f0cc4d7aac47

failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=207257453&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-6%2Cm-e10s%28bc6%29

backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/0920d2b1122d3e364ab7a49be99788b9596e07b0

Comment 11

[Eden Chuang[:edenchuang]]

Attachment: Define a new IPC structure for response data

Fix the memory leak.

Comment 12

[Eden Chuang[:edenchuang]]

Try result

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b649bc60423c2a9178f48ce80e35c5b768fa9d57
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c2eb0a78a7f6e380700c0e6da46fc16f0074934

Comment 13

[Natalia Csoregi [:nataliaCs]]

Pulsebot is down atm.

Land: https://hg.mozilla.org/integration/mozilla-inbound/rev/4b9fa41aa4ecbf8079011d1906f4287493434d70

Removing checkin-needed.

Comment 14

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4b9fa41aa4ec

Comment 15

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 65.0a1 (2018-10-29) on Windows 10 x 64, Windows 7 x32, Mac OS X 10.14 and on Ubuntu 16.04 x64.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

AFAIK, this doesn't need backporting since WebPayments are still Nightly-only, but feel free to nominate for Beta uplift if I'm mistaken.