1497479 - Fix indentation in discardBrowser

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Dão Gottwald [:dao]]

These conditions of the if-clause lack two spaces of indentation:

https://searchfox.org/mozilla-central/rev/29aea2a2a3bd0f5e25ce0b60a76053fb25ba5149/browser/base/content/tabbrowser.js#2117-2122

Comment 1

[andrewjgregoryajg]

I'd love to take this on as my first contribution - how do I actually edit the file in question?

Comment 2

[Dão Gottwald [:dao]]

(In reply to andrewjgregoryajg from comment #1)
> I'd love to take this on as my first contribution - how do I actually edit
> the file in question?

Do you have the source code yet? See https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code

Comment 3

[andrewjgregoryajg]

(In reply to Dão Gottwald [::dao] from comment #2)
> (In reply to andrewjgregoryajg from comment #1)
> > I'd love to take this on as my first contribution - how do I actually edit
> > the file in question?
> 
> Do you have the source code yet? See
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code

That link is very helpful, thanks! I am going through it right now and will let you know if I have any other questions.

Comment 4

[andrewjgregoryajg]

Attachment: Bug 1497479 - Fix indentation in discardBrowser

Comment 5

[andrewjgregoryajg]

Attachment: Bug 1497479 - add newline at end of file

Comment 6

[Dão Gottwald [:dao]]

Could you please combine both commits into one?

Comment 7

[andrewjgregoryajg]

Do you mean combine these two attachments or combine the two commits here: https://phabricator.services.mozilla.com/D8559 into one?

Comment 8

[Dão Gottwald [:dao]]

I mean the two phabricator commits...

Comment 9

[aditya81070]

(In reply to Dão Gottwald [::dao] from comment #8)
> I mean the two phabricator commits...

I would like to work on this issue if @andrewjgregoryajg is not doing this.

Comment 10

[andrewjgregoryajg]

I am still working on this but I have yet to figure out how to combine two Phabricator commits. I've read the Phabricator docs and couldn't find anything. Can anyone point me in the right direction?

Comment 11

[Dão Gottwald [:dao]]

Maybe just discard the previous commits and create a completely new one.

Comment 12

[Dão Gottwald [:dao]]

I now accepted your patch removing tabbrowser.js' last line since it's not a big deal.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/745dab0eb011
Fix indentation in discardBrowser r=dao

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/745dab0eb011

Comment 15

[andrewjgregoryajg]

Thanks for being patient. I am still trying to get the hang of all of these new tools (Phabricator, Mercurial, etc) so I appreciate the time you've taken to respond here.