1497852 - Flickering effect on menu bar

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Daniel_A[:daschilean] [Please contact - [e-mail]]]

Attachment: FlickeringEffect.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0 
Build ID: 20181009220508

[Affected versions]:
Nightly 64.0a1 (2018-10-09) (64-bit) and Nightly 64.0a1 (2018-10-09) (32-bit)

[Affected platforms]:
Windows 10 x86, Windows 10 x64

[Steps to reproduce]:
1. Launch Firefox with a new profile
2. Type about:config
3. Set gfx.webrender.all.qualified =  true
4. Navigate to http://www.playmag.fr/heroesoftomorrow
5. Switch between "ALOY" and "KARA" option from the menu bar

[Expected result]:
The image should be displayed without any flickering effect.

[Actual result]:
Flickering effect is encountered after switching between "ALOY" and "KARA" from the top menu.

Comment 1

[Darkspirit]

mozregression --good 2018-07-01 --bad 2018-10-09 --pref gfx.webrender.all:true -a http://www.playmag.fr/heroesoftomorrow
> 15:50.42 INFO: Last good revision: 8b5693e79dfd980f754bf04c06f1e1f6da5514fe
> 15:50.42 INFO: First bad revision: 6ea17dfcb278cbc22891a77d3e1baa82614c38ab
> 15:50.42 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8b5693e79dfd980f754bf04c06f1e1f6da5514fe&tochange=6ea17dfcb278cbc22891a77d3e1baa82614c38ab

> 6ea17dfcb278	Jeff Muizelaar — Bug 1477505. Update webrender to commit e850fbd2e0e60a8de76c2d2464f0fa27316d5949

Regression range: https://github.com/servo/webrender/compare/c2c5aaebdd6df22ce13941c1a4b16ef47eaa9f7b...e850fbd2e0e60a8de76c2d2464f0fa27316d5949

Probably servo/webrender#2926: Avoid always reuploading blob images.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking fix-optional for 64. We could still take a patch for 65, and if it's verified and doesn't seem risky, could still take fixes for 64 as well.

Comment 3

[Sotaro Ikeda [:sotaro]]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #1)
> mozregression --good 2018-07-01 --bad 2018-10-09 --pref
> gfx.webrender.all:true -a http://www.playmag.fr/heroesoftomorrow
> > 15:50.42 INFO: Last good revision: 8b5693e79dfd980f754bf04c06f1e1f6da5514fe
> > 15:50.42 INFO: First bad revision: 6ea17dfcb278cbc22891a77d3e1baa82614c38ab
> > 15:50.42 INFO: Pushlog:
> > https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8b5693e79dfd980f754bf04c06f1e1f6da5514fe&tochange=6ea17dfcb278cbc22891a77d3e1baa82614c38ab
> 
> > 6ea17dfcb278	Jeff Muizelaar — Bug 1477505. Update webrender to commit e850fbd2e0e60a8de76c2d2464f0fa27316d5949
> 


When I checked with mozregression, a result was different like the following.

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8984f6868e572079cc991492124ba99747f0f681&tochange=80efe717b563f329a2261a8d23f4ebbc470c432f

In this case, Bug 1494164 might be similar.

Comment 4

[Darkspirit]

Still reproducible on Win10/GTX1060.

Comment 5

[Sotaro Ikeda [:sotaro]]

A patch in Bug 1505363 address the problem for me.

Comment 6

[Sotaro Ikeda [:sotaro]]

I confirmed that the problem was addressed on latest nightly.

Comment 7

[Darkspirit]

Yes, thank you!

Comment 8

[Rares Doghi, Desktop QA]

Hi, This issue is Verified as Fixed in the Latest Nightly 67.0a1 (2019-02-07) as well as Beta 66.0b5, I will mark this issue accordingly.