Closed
Bug 1498245
Opened 6 years ago
Closed 6 years ago
Scalar parser tests not checking that no errors happened
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: janerik, Assigned: janerik)
Details
Attachments
(1 file)
The python test for the scalar parser[1] is not checking that the parser did not actually fail. It needs to call `ParserError.exit_func()` which will raise (and thus fail the test) if something failed during parsing.
Assignee | ||
Comment 1•6 years ago
|
||
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2a823a4e707 Call exit_func to raise any errors if parsing failed r=chutten
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a2a823a4e707
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•