Closed Bug 1498497 Opened 6 years ago Closed 5 years ago

Update TBDistCustomizer.jsm to match Firefox version; stop using eval

Categories

(Thunderbird :: General, enhancement)

Product:
Thunderbird
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 66.0

People

(Reporter: darktrojan, Assigned: aceman)

Details

Attachments

(1 file)

1498497.patch
6.48 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review 
mail/base/modules/TBDistCustomizer.jsm is our equivalent of browser/components/distribution.js

Bug 1251729 removed the use of eval from distribution.js. We should do the same, because eval is bad.

There might be other fixes we can take too.
And mail/base/test/unit/test_mailGlue_distribution.js, while we're at it.
Attached patch 1498497.patch — — Splinter Review

I put the parseValue() inside of TBDistCustomizer so it can be called from the test. That differs slightly from the Firefox version.

Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #9038926 - Flags: review?(jorgk)
Comment on attachment 9038926 [details] [diff] [review]
1498497.patch

Looks good comparing to the M-C code.
Attachment #9038926 - Flags: review?(jorgk) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0a405faf8b1d
Stop using eval in TBDistCustomizer.jsm to match Firefox. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: