Closed Bug 1499092 Opened 6 years ago Closed 5 years ago

Move registerProtocolHandler code out of browser/components/feeds/

Categories

(Firefox :: General, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 66
Tracking Status
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

(Whiteboard: [fxperf:p3])

Attachments

(2 files)

It doesn't really have anything to do with feeds.

I think ideally we should be able to push more of the implementation down into DOM code, and have the DOM code explicitly ask the parent process for permission. Then we can get rid of the content-process side JS that currently handles forwarding the request to frontend code, which will also make it easier to share code with mobile / geckoview.

Ideally the protocol handling backend stuff would also be handled in DOM code, though I'm not sure if that's feasible today.
To be clear, this should also move/rename the strings from `subscribe.properties` ( https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/feeds/subscribe.properties )
Might be able to just do this as part of fxperf - removing all the content process JS machinery here should improve content process size + startup stuff.
Whiteboard: [fxperf]
Whiteboard: [fxperf] → [fxperf:p3]
Priority: -- → P3
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #9029344 - Attachment description: Bug 1499092 - move bulk of registerProtocolHandler checks into compiled code so we don't need a dedicated component in the child process, r?nika!,jkt! → Bug 1499092 - move bulk of registerProtocolHandler checks into compiled code so we don't need a dedicated component in the child process, r?nika!
Attachment #9029346 - Attachment description: Bug 1499092 - rename/move code from 'feeds' and 'web content' to more appropriate/obvious versions for registerProtocolHandler, r?nika!,jkt! → Bug 1499092 - rename/move code from 'feeds' and 'web content' to more appropriate/obvious versions for registerProtocolHandler, r?nika!
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b51f62289b9a
move bulk of registerProtocolHandler checks into compiled code so we don't need a dedicated component in the child process, r=nika
https://hg.mozilla.org/integration/autoland/rev/13078c094de9
rename/move code from 'feeds' and 'web content' to more appropriate/obvious versions for registerProtocolHandler, r=nika
https://hg.mozilla.org/mozilla-central/rev/b51f62289b9a
https://hg.mozilla.org/mozilla-central/rev/13078c094de9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Regressions: 1541909
Regressions: 1717833
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: