Closed Bug 1499236 Opened 6 years ago Closed 6 years ago

Remove the customizable ui toolbar-menubar-autohide binding

Categories

(Firefox :: Toolbars and Customization, task, P1)

Product:
Firefox
Component:
Toolbars and Customization
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: bgrins, Assigned: Gijs)

References

Details

Attachments

(1 file)

Bug 1499236 - remove customizableui menubar binding, r?felipe!
46 bytes, text/x-phabricator-request
Details | Review 
See discussion starting at https://bugzilla.mozilla.org/show_bug.cgi?id=1498740#c4.

This binding (https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/browser/components/customizableui/content/toolbar.xml#170) can be removed and replaced with JS running somewhere from browser.xul, since this is a 1-binding-per-browser-window setup.
Gijs, filed as discussed in https://bugzilla.mozilla.org/show_bug.cgi?id=1498740#c5. Is this something you'd have cycles to grab? If not, do you have any more information to add here for whoever takes it as far as where the ported code should live / get initialized?
Component: XUL Widgets → Toolbars and Customization
Flags: needinfo?(gijskruitbosch+bugs)
Product: Toolkit → Firefox
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to :Gijs (he/him) from comment #3)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=123784e962859809902dcfcf657ca4fd90ebd44b

Hm, this seems to trip up the reflow test for window opening on Windows (but not linux...). I'll need to investigate why when I'm back on my Windows machine.
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5c84e7821c57
remove customizableui menubar binding, r=Felipe
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/5c84e7821c57
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: