Closed
Bug 1499255
Opened 6 years ago
Closed 6 years ago
Android: Crash when android SurfaceTexture is used(Video, WebGL)
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: jan, Assigned: sotaro)
References
(Depends on 1 open bug, Blocks 1 open bug, )
Details
(Keywords: nightly-community)
Attachments
(1 file, 4 obsolete files)
12.93 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
(Markus Stange [:mstange] from bug 1498735 comment 0) > [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=73edcb2dabe7c97460516ecaf7fb843c35235bab&selectedJob=205166206 Device: Moto G5 Nightly crashes if you play a video on any website.
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•6 years ago
|
||
I could reproduce the problem.
Assignee | ||
Comment 2•6 years ago
|
||
Before Bug 1502454 fix, I saw a crash at ClipManager::PushOverrideForASR(). Since Bug 1502454 fix, I saw the crash at TextureHost::CreateRenderTexture().
Assignee | ||
Comment 3•6 years ago
|
||
SurfaceTextureHost does not support CreateRenderTexture() yet. It caused a crash.
Assignee | ||
Comment 4•6 years ago
|
||
For debugging on android, I used Android Studio. https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build#Developing_Firefox_for_Android_in_Android_Studio
Comment hidden (obsolete) |
Assignee | ||
Comment 6•6 years ago
|
||
During debugging, I saw that rust Log does not work as expected. Setting of the log seems not set as expected on android. log::STATIC_MAX_LEVEL was set to WARN, but we expect it to INFO from https://dxr.mozilla.org/mozilla-central/source/toolkit/library/rust/shared/Cargo.toml#28 log::max_level() was always set to ERROR. GeckoLogger setting was overridden by someone.
Comment hidden (obsolete) |
Assignee | ||
Comment 8•6 years ago
|
||
attachment 9024945 [details] [diff] [review] has the following problem. They are going to be addressed another new bugs. - [1] mIgnoreTransform is not handled yet. - [2] mContinuousUpdate is not handled yet. - [3] Shader compilation failed when GL_OES_EGL_image_external_essl3 is not supported.
Assignee | ||
Updated•6 years ago
|
Attachment #9023184 -
Attachment is obsolete: true
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Assignee | ||
Comment 11•6 years ago
|
||
Attachment #9024957 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Attachment #9024962 -
Flags: review?(nical.bugzilla)
Assignee | ||
Updated•6 years ago
|
Summary: Android: Videos are crashing Nightly → Android: Crash when android SurfaceTexture is used(Video, WebGL)
Comment 12•6 years ago
|
||
Comment on attachment 9024962 [details] [diff] [review] patch - Make SurfaceTextureHost to support WebRender Review of attachment 9024962 [details] [diff] [review]: ----------------------------------------------------------------- Please make sure to have bugs on file for the missing pieces, in particular the implementation of RenderAndroidSurfaceTextureHostOGL::DeleteTextureHandle.
Attachment #9024962 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 13•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=df8c1e3b0685b485fa032b8fb2a74c2cff862f12
Comment 14•6 years ago
|
||
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b5ebe325c20d Make SurfaceTextureHost to support WebRender r=nical
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b5ebe325c20d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•