1499706 - Make TabsInTitlebar.update private

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

In bug 1356920, browser-tabsintitlebar.js and a bunch of our CSS was refactored to move a bunch of layout calculations out from JS and into our layout engine. We suspect that TabsInTitlebar.update no longer needs to be public, and that we can stop calling it from browser-fullScreenAndPointerLock.js.

I tried to do this in bug 1356920, but hit this weird state in the browser screenshots suite:

https://screenshots.mattn.ca/comparisons/try/b353994a94138de59232094fc8da7d7916ca53f1/try/8623452e62dafb1c9c38b91de1b0ec4b49e2a82f/windows10-64/primaryUI_273_tabsOutsideTitlebar_fiveTabs_maximized_onlyNavBar_noLWT_touchDensity.png

It looks like there is a case where making TabsInTitlebar private and removing the call from browser-fullScreenAndPointerLock.js is breaking how we disable TabsInTitlebar in the screenshots suite. We should figure that out, and then get TabsInTitlebar.update made private.

Comment 1

[Dão Gottwald [:dao]]

https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=1bb0b4bc5f8e8dfce23577f01b7eec21b150920d&newProject=try&newRev=38f18c4f99858fe3c8b128e96ff06e6921ed6e30

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1499706 - Remove external calls to TabsInTitlebar.update and make it private. r?mconley

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7d37169919d
Remove external calls to TabsInTitlebar.update and make it private. r=mconley

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a7d37169919d