1500416 - Dynamic insertion of display: contents elements doesn't work.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

The check in here:

  https://searchfox.org/mozilla-central/rev/c56977420df7a1b692ce0f7e499ddb364d9fd7b2/accessible/base/NotificationController.cpp#432

Doesn't work for display: contents elements, which don't have a frame.

So that check probably needs to be extended to handle display: contents as well.

Should be reproducible inserting something like <ul style="display: contents"> dynamically.

Comment 1

[James Teh [:Jamie]]

Thanks for catching. Confirmed:
data:text/html,<div id="div"></div><button onClick="div.innerHTML = `<ul style='display: contents;'><li>1</li></ul>`;">Add</button>
When the Add button is pressed, you see the "1" text in the accessibility tree, but no accessible for the list.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1500416 - Account for display: contents in ScheduleContentInsertion.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d15bcd82f19d
Account for display: contents in ScheduleContentInsertion. r=Jamie

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd985440b6e2
Fixup to avoid triggering the trailing commas lint on a CLOSED TREE.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d15bcd82f19d
https://hg.mozilla.org/mozilla-central/rev/fd985440b6e2