1500486 - QuantumBar: Handle loading of non-urls entered in the address bar correctly

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Mark Banner (:standard8)]

This is to implement the functionality that looks at text entered on the address bar (e.g. via paste and go) and works out if it is a keyword or simple search and gets the loads the appropriate URL.

This looks like we need to uncomment the getShortcutOrURIAndPostData section in UrlbarController.handleEnteredText and get it working correctly.

We may need to move getShortcutOrURIAndPostData to a .jsm, and there may be other structural changes required depending on the outcome of bug 1500483.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1500486 - QuantumBar: Handle loading of non-urls entered in the new address bar. r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6745799b8cbf
QuantumBar: Handle loading of non-urls entered in the new address bar. r=dao

Comment 3

[Eliza Balazs [:ebalazs_]]

Backed out changeset 6745799b8cbf (Bug 1500486) for X1 perma failures in browser/components/extensions/test/xpcshell/test_ext_url_overrides_newtab.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&selectedJob=218352132&revision=3a328e80b02cf3c11a36e060380277396e211cd9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=218352132&repo=autoland&lineNumber=1989

Backout: https://hg.mozilla.org/integration/autoland/rev/a5beb6bc609d79a7e44a006a05a5ed24f2c601bf

Comment 4

[Mark Banner (:standard8)]

Confirmed on irc that these failures aren't related to my push.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/007bbc7c20ef
QuantumBar: Handle loading of non-urls entered in the new address bar. r=dao

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/007bbc7c20ef