Closed
Bug 1501977
Opened 6 years ago
Closed 6 years ago
Remove global Content Blocking toggle in the main menu and about:preferences
Categories
(Firefox :: Protections UI, enhancement, P1)
Firefox
Protections UI
Tracking
()
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: johannh, Assigned: johannh)
References
(Blocks 1 open bug)
Details
(Whiteboard: [privacy65])
Attachments
(2 files)
The updated design spec switches from having a global toggle for content blocking to "Standard", "Strict" and "Custom" modes (https://mozilla.invisionapp.com/share/RHORBWDNX4W#/screens). We also want to remove the browser.contentblocking.enabled pref. Thus, we'd like to remove the global toggles again.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: P2 → P1
Assignee | ||
Comment 1•6 years ago
|
||
This patch also removes some of the other handling of browser.contentblocking.enabled in about:preferences, such as disabling the cookies and site data section.
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Ah, I didn't realize that bug 1502076 had landed on central already. I'll need to rebase on that.
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/74a560ef3b51 Remove global Content Blocking toggle in about:preferences. r=flod,Ehsan https://hg.mozilla.org/integration/autoland/rev/e1404c73b666 Remove global Content Blocking toggle in the main menu. r=Ehsan
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/74a560ef3b51 https://hg.mozilla.org/mozilla-central/rev/e1404c73b666
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment 6•6 years ago
|
||
We gain some perf boost! \0/ == Change summary for alert #17179 (as of Fri, 26 Oct 2018 15:17:05 GMT) == Improvements: 5% about_preferences_basic windows7-32 opt e10s stylo 136.09 -> 129.60 3% about_preferences_basic windows10-64-qr opt e10s stylo 138.72 -> 134.60 3% about_preferences_basic windows10-64 opt e10s stylo 137.55 -> 134.03 2% about_preferences_basic linux64-qr opt e10s stylo 148.15 -> 145.27 2% about_preferences_basic osx-10-10 opt e10s stylo 202.44 -> 198.70 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=17179
You need to log in
before you can comment on or make changes to this bug.
Description
•