1502761 - Add reftests for ImageRendering on video (NativeTexture external images)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Henrik Winnemöller]

Bug 1488555 added the ability to support ImageRendering on video (NativeTexture external images). While working on this bug, I realised that:

- The ImageRendering property on videos (NativeTexture external image) is not tested.
- JS-based changes to the ImageRendering property of a video (NativeTexture external image) are not tested.
- We do not test if the ImageRendering field actually produces any changes. Therefore, a reftest should check for inequality between different ImageRendering settings.

This bug will introduce additional reftests for these cases.

Comment 1

[Henrik Winnemöller]

Attachment: 4-Bug_1502761___Add_reftests_for_ImageRendering_on_video__NativeTexture_external_images___r_nical.diff

Try run including the tests from Bug 1502759, Bug 1502761, Bug 1502762:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=08351aef6331c770cb5f1ce8c2e27c81371ec793

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 9020660 [details] [diff] [review]
4-Bug_1502761___Add_reftests_for_ImageRendering_on_video__NativeTexture_external_images___r_nical.diff

Review of attachment 9020660 [details] [diff] [review]:
-----------------------------------------------------------------

Apologies for the delay, looks good to me!

Comment 3

[Henrik Winnemöller]

Attachment: 4-Bug_1502761___Add_reftests_for_ImageRendering_on_video__NativeTexture_external_images___r_nical.diff

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62d95b920270
Add reftests for ImageRendering on video (NativeTexture external images). r=nical

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for reftest failures on image-rendering-css.html

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/187bd02adc127a48c3f76a44df2294534a7513c0
Push link: https://hg.mozilla.org/integration/mozilla-inbound/rev/62d95b920270c7f324f77801ae7334dbf148fddd
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=208983362&repo=mozilla-inbound&lineNumber=1671

There were also tier2 TVg failures ".../mp4-video/reftest.list line 4: minimum fuzz must be zero for tests of type != "
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=208984003&repo=mozilla-inbound&lineNumber=940

Comment 6

[Henrik Winnemöller]

Attachment: 4-Bug_1502761___Add_reftests_for_ImageRendering_on_video__NativeTexture_external_images___r_nical.diff

(In reply to Narcis Beleuzu [:NarcisB] from comment #5)
> Backed out for reftest failures on image-rendering-css.html
> Log link:
> https://treeherder.mozilla.org/logviewer.html#?job_id=208983362&repo=mozilla-
> inbound&lineNumber=1671

Fennec seems to have an issue where the first video frame is always black, see Bug 1370426. This also blocks Bug 1368902. I have disabled the tests on Fennec/Android and will create a new bug to track this issue.

> There were also tier2 TVg failures ".../mp4-video/reftest.list line 4:
> minimum fuzz must be zero for tests of type != "
> Log link:
> https://treeherder.mozilla.org/logviewer.html#?job_id=208984003&repo=mozilla-
> inbound&lineNumber=940

I have adapted the fuzz minimum values.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db853d5005c7
Add reftests for ImageRendering on video (NativeTexture external images). r=nical

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/db853d5005c7