1503760 - browser.downloads.search doesn't return 0 byte downloads

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P5)

Description

[Joseph Wensley]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

I generated a 0 byte file using the following code

<?php
header('Content-Description: File Transfer');
header('Content-Type: application/octet-stream');
header('Content-Disposition: attachment; filename="test.bin"');
header('Content-Transfer-Encoding: binary');
header('Content-Length: ' . 0);
die;

And then tried to query for the download using browser.downloads.search({})



Actual results:

No results were returned


Expected results:

The download should have been returned

Comment 1

[David Durst [:ddurst]]

Does this actually get created on the filesystem and is it shown in the download section of the library?

Comment 2

[Joseph Wensley]

(In reply to David Durst [:ddurst] (Regression Engineering Owner for 63) from comment #1)
> Does this actually get created on the filesystem and is it shown in the
> download section of the library?

Yes, the files are created on the filesystem and they show up in the library.

Comment 3

[Andrew Swan [:aswan]]

The issue is here:
https://searchfox.org/mozilla-central/rev/007b66c1f5f7a1b9a900a2038652a16a020f010c/toolkit/components/extensions/parent/ext-downloads.js#269

If the totalBytesGreater query property isn't specified we default to 0 which means search() only returns those with a size > 0.  Changing the default there to -1 should fix this.  It could also use a test.

Comment 4

[Caitlin Neiman [:caitmuenster]]

If this is your first contribution, please see https://wiki.mozilla.org/WebExtensions/Contribution_Onramp for information on getting started.

Comment 5

[Ben Armstrong]

Hi, I'll be taking a look at trying to fix this, thanks.

Comment 6

[Caitlin Neiman [:caitmuenster]]

Welcome, Ben! If you need any help, please needinfo :aswan, the bug mentor. 

Happy bug fixing!

Comment 7

[Ben Armstrong]

Hi Andrew,

To test this where do I execute the code Joseph Wensley provided to reproduce?

Thanks!

Comment 8

[Andrew Swan [:aswan]]

I don't think you need to use his specific code, just making a 0 byte file available via http (either by putting it on the filesystem where an http server can read it or by writing your own handler for your web server framework of choice) is fine.

Comment 9

[Ben Armstrong]

Attachment: Bug 1503760: Changed browser.downloads.search({}) to return 0 byte downloads. r=aswan

Updated the totalBytesGreater property in browser.downloads.search({}) to default to -1 so files with a byte size of 0 will be returned.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e990a032ac3c
Changed browser.downloads.search({}) to return 0 byte downloads. r=aswan

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/e990a032ac3c

Comment 12

[CosminB]

Attachment: Bug1503760.zip

I was able to reproduce this issue on Firefox 63.0.3(20181114214635) under Win 7 64-bit and  Mac OS X 10.13.6.

This issue is verified as fixed on Firefox 66.0a1(20181211093801) and 65.0b3(20181210164452) under Win 7 64-bit and Mac OS X 10.13.6.

I used: https://github.com/mdn/webextensions-examples/tree/ec731d4ceee1df0ccdebd87ab9f95875f55eeee7/latest-download and Xampp for testing.

Please see the attached screenshots.