1505031 - JavaScript error: aboutPerformance.js, ReferenceError: event is not defined

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[Florian Quèze [:florian]]

[Tracking Requested - why for this release]: this code works on Nightly but will fail on beta and release.

JavaScript error: chrome://global/content/aboutPerformance.js, line 1104: ReferenceError: event is not defined

And same error at line 1158.

This happens when dom.window.event.enabled is false, which is true for release builds since bug 1493869.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a62566c1baf
stop using the global 'event' object in about:performance, r=felipe.

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/1a62566c1baf

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 9022944 [details] [diff] [review]
Patch

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: 1491384, 1496782

User impact if declined: Clicking or double clicking won't work (and will produce a JS error in the browser console) in about:performance on release builds.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: none

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Trivial fix

String changes made/needed: none

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9022944 [details] [diff] [review]
Patch

trivial fix for new about:performance, approved for 64.0b8

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4bf79d20c644