Closed
Bug 1505197
Opened 6 years ago
Closed 6 years ago
asyncReauthenticateUser doesn't retry upon failure (unlike macOS)
Categories
(Core :: Security: PSM, enhancement, P1)
Tracking
()
VERIFIED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | verified |
People
(Reporter: MattN, Assigned: franziskus)
References
Details
(Whiteboard: [webpayments-reserve])
Attachments
(1 file)
If the user enters an incorrect password, they aren't given a chance to try again. I'm not sure if this is an option with the API or whether we can implement our own retry counter. The main issue is that this behaviour isn't consistent with the macOS version of asyncReauthenticateUser
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → franziskuskiefer
|
||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
|
|
Assignee | |
Comment 1•6 years ago
|
||
This adds a hard coded number of retries for Windos re-auth. I'm not sure if we want the amount of retries to be fixed or part of the API. I also changed to always return NS_OK unless a real error occured to make this behave like the macOS version.
Blocks: 1502121
|
|
||
Updated•6 years ago
|
Flags: qe-verify+
QA Contact: hani.yacoub
Pushed by franziskuskiefer@gmail.com: https://hg.mozilla.org/integration/autoland/rev/37dc10164964 allow the user to retry reauthentication on Windows 2 times r=keeler
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/37dc10164964
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
||
Comment 4•6 years ago
|
||
Verified as fixed on Firefox Nightly 65.0a1 (2018-11-14) on Windows 10 x 64 and Windows 7 x32.
You need to log in
before you can comment on or make changes to this bug.
Description
•