Closed
Bug 1505343
Opened 6 years ago
Closed 5 years ago
[BinAST] Rename binsource => binast
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: Yoric, Assigned: arai)
References
Details
Attachments
(3 files)
Now that we have de facto agreed on a name, we should probably rename everything binsource into binast. Low priority.
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•6 years ago
|
||
I'll do part of this in bug 1508063, and do remaining here.
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D23097
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D23098
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/c1e2b7779d6a Part 1: Rename binsource => binast. r=Yoric https://hg.mozilla.org/integration/autoland/rev/b2456f6d11c4 Part 2: Rename BinToken* to BinASTToken*. r=Yoric https://hg.mozilla.org/integration/autoland/rev/4ac13d1f0d7c Part 3: Rename Bin{Kind,Field,Variant} to BinAST{Kind,Field,Variant}. r=Yoric
Comment 6•5 years ago
|
||
Backed out 3 changesets (Bug 1505343) for build bustages in testBinASTReader.cpp CLOSED TREE
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233541347&repo=autoland&lineNumber=2042
Backout: https://hg.mozilla.org/integration/autoland/rev/7cbe3fbc4b7f1c76a14ce40f074f8a9052540ee5
Flags: needinfo?(arai.unmht)
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/123ecc5c9586 Part 1: Rename binsource => binast. r=Yoric https://hg.mozilla.org/integration/autoland/rev/976e93ae2dbc Part 2: Rename BinToken* to BinASTToken*. r=Yoric https://hg.mozilla.org/integration/autoland/rev/639ba2db3684 Part 3: Rename Bin{Kind,Field,Variant} to BinAST{Kind,Field,Variant}. r=Yoric
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/123ecc5c9586
https://hg.mozilla.org/mozilla-central/rev/976e93ae2dbc
https://hg.mozilla.org/mozilla-central/rev/639ba2db3684
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•