1506050 - Titlebar active appearance is opposite to what is expected when switching windows

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Kestrel]

Switch focus between Firefox and another application window and observe the titlebar active appearance. Instead of gaining active appearance when the window becomes focused it switches to inactive appearance and vice versa when losing focus. Moving the mouse cursor over the titlebar updates the active appearance to the correct state.

Regressed by Bug 1497534

Ubuntu 18.10 with default Yaru theme.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Okay, will look at it. I wonder if the backdrop state change is slower that the focus one and the titlebar widget is rendered before main window state is updated by Gtk.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Yes, I see that even on Fedora. When the application switch is fast, the firefox window is not repainted.

I suspect it's something with event routing, when I log events at nsWindow::OnWindowStateEvent() the focus is correctly received from Gtk but the titlebar does not react on that.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1506050 - [Linux/Gtk] Use NS_DOCUMENT_STATE_WINDOW_INACTIVE to set titlebar state, r=jhorak

Comment 4

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2298d8073a5d83b410b8ef06ce566c1ea84eacab

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf1a01ae1faa
[Linux/Gtk] Use NS_DOCUMENT_STATE_WINDOW_INACTIVE to set titlebar state, r=jhorak

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/bf1a01ae1faa

Comment 7

[Maria Berlinger [:mberlinger], Services QA]

Attachment: Peek 2019-01-29 12-05.gif

Comment 8

[Maria Berlinger [:mberlinger], Services QA]

I've tried to reproduce this bug using Ubuntu 18.14 x64 but unfortunately I couldn't.
I've attached the screencast, maybe I'm doing something wrong?

Kestrel, can you please tell me if I'm doing the right thing or give me some more info?

Comment 9

[Dão Gottwald [:dao]]

(In reply to Maria Berlinger [:maria_berlinger], Release Desktop QA from comment #8)

I've tried to reproduce this bug using Ubuntu 18.14 x64 but unfortunately I couldn't.
I've attached the screencast, maybe I'm doing something wrong?

Kestrel, can you please tell me if I'm doing the right thing or give me some more info?

You need to disable the native title bar in customize mode.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

(In reply to Maria Berlinger [:maria_berlinger], Release Desktop QA from comment #8)

I've tried to reproduce this bug using Ubuntu 18.14 x64 but unfortunately I
couldn't.
I've attached the screencast, maybe I'm doing something wrong?

Kestrel, can you please tell me if I'm doing the right thing or give me some
more info?

This should be already fixed in Firefox 64/65 so there's no recent version where you can see this bug unless you take a beta from past. Also the bug happened when you switched firefox and another application (terminal, gedit...) by ALT+TAB keys, not by mouse.

Comment 11

[Kestrel]

(In reply to Martin Stránský [:stransky] from comment #10)

no recent version where you can see this bug unless you take a beta from past.

There is no Beta that had this, it only existed in Nightly.

Last bad Nightly:
https://ftp.mozilla.org/pub/firefox/nightly/2018/11/2018-11-20-10-00-45-mozilla-central/

First good Nightly:
https://ftp.mozilla.org/pub/firefox/nightly/2018/11/2018-11-20-22-01-33-mozilla-central/

Also the bug happened when you switched firefox and another application (terminal, gedit...) by ALT+TAB keys, not by mouse.

It happened for me regardless of the method of switching windows (keyboard and mouse) and between windows of the same Firefox instance. However if you click on the titlebar to switch focus it will appear active so it's better to click elsewhere in the window.

Comment 12

[Maria Berlinger [:mberlinger], Services QA]

Thank you.
I've reproduce it.
This is verified fixed on Firefox 66.0b3 and Firefox 67.0a1 (20190128214724) using Ubuntu 18.04 x64.