1506601 - GeckoView requires android-support, but does not appear in maven pom

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P3)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

GeckoView uses the android-support library, but this is not correctly communicated to applications. The Right Way appears to be for it to appear in the maven pom file, and then gradle will do its thing. Our pom file appears to be empty right now.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Nick, would you mind taking a look? It seems like this is supposed to be happening automatically, but it's not -- perhaps because of the "specialness" of our build?

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #1)
> Nick, would you mind taking a look? It seems like this is supposed to be
> happening automatically, but it's not -- perhaps because of the
> "specialness" of our build?

Sure.  As it happens I was deep-diving into this for some application-services work.  A little investigation shows that we're not really using any of the Maven publishing Gradle apparatus; we're kind-of rolling our own in

https://searchfox.org/mozilla-central/rev/007b66c1f5f7a1b9a900a2038652a16a020f010c/mobile/android/geckoview/build.gradle#297-321

I'll think a little and suggest an alternative.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1506601 - Add dependencies to GeckoView's pom file. r?nalexander

This adds GeckoView dependencies to the Maven pom file by iterating through the
"implementation" dependencies and adding them manually to the pom XML.

This workaround can be removed when issue [0] is fixed.

This also moves the publishing from the old 'maven' plugin to the new
'maven-publishing' see also [1] and [2].

[0]: https://github.com/gradle/gradle/issues/1842
[1]: https://docs.gradle.org/current/userguide/maven_plugin.html
[2]: https://docs.gradle.org/current/userguide/publishing_maven.html#publishing_maven

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

One side benefit of the above is that now mavenLocal works out of the box! We can publish geckoview to a maven local repo by calling |./mach gradle geckoview:publishMainPublicationToMavenLocal|

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1b7c5e6291e
Add dependencies to GeckoView's pom file. r=nalexander

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f1b7c5e6291e

Comment 7

[Chris Peterson [:cpeterson]]

64=wontfix because we don't need this maven pom fix for Focus 8.0.