1507809 - Remove ExcludeReadOnlyFolders option from places' queries

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P2)

Description

[Mark Banner (:standard8)]

"ExcludeReadOnlyFolders" was used for excluding livemarks, since we didn't support any other form of read-only folders (and won't do).

When bug 1502954 lands, that will make it do nothing, so we should just remove it as well.

Comment 1

[Mark Banner (:standard8)]

I'm happy to mentor anyone on this. There is a mixture of javascript and C++ work, and it will need a full Firefox build.

All references to "excludeReadOnlyFolders" should be removed, see this for a handy list:

https://searchfox.org/mozilla-central/search?q=ExcludeReadOnlyFolders&case=false&regexp=false&path=

Once you've removed the references, rebuild Firefox, and then run the main tests associated with this code:

```
$ ./mach xpcshell-test toolkit/components/places
$ ./mach mochitest browser/components/places
```

If all is well, there should be no issues.

Please submit a patch via phabricator: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Comment 2

[Ferenc Nagy]

Hey Mark,

I would like to try this one. Although I'm not very familiar with the codebase, this one seems like an easy fix

Comment 3

[James Lee]

Attachment: Bug 1507809 - Remove 'ExcludeReadOnlyFolders' option from places' queries

Removed all references to 'ExcludeReadOnlyFolders' since Firefox doesn't 
(and will not) support read only folders.

Comment 4

[Ferenc Nagy]

(In reply to James Lee from comment #3)
> Created attachment 9027326 [details]
> Bug 1507809 - Remove 'ExcludeReadOnlyFolders' option from places' queries
> 
> Removed all references to 'ExcludeReadOnlyFolders' since Firefox doesn't 
> (and will not) support read only folders.

Next time please write a comment on the bug before you start working on it

Comment 5

[James Lee]

(In reply to Ferenc Nagy from comment #4)
> (In reply to James Lee from comment #3)
> > Created attachment 9027326 [details]
> > Bug 1507809 - Remove 'ExcludeReadOnlyFolders' option from places' queries
> > 
> > Removed all references to 'ExcludeReadOnlyFolders' since Firefox doesn't 
> > (and will not) support read only folders.
> 
> Next time please write a comment on the bug before you start working on it

Apologies if you had started any work on this; Mark explained to me in my last bug that I could just submit a patch without asking to be assigned. I may have taken that a little to literally. I will leave a comment before I start a bug next time.

Comment 6

[Mark Banner (:standard8)]

Yeah, sorry I'll change my text in future. It is generally a good idea to indicate if you're working on a bug, but you don't necessarily have to wait for the actual assignment.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/693821f7cf93
Remove 'ExcludeReadOnlyFolders' option from places' queries r=Standard8

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/693821f7cf93