1508983 - Enable ESLint for dom/base/test/chrome and dom/base/test/unit

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Mark Banner (:standard8)]

As part of rolling out ESLint across the tree, we should enable it for dom/base/test/chrome and dom/base/test/unit.

Comment 1

[mordax]

May I work on this?

Comment 2

[mordax]

Attachment: Bug 1508983 - Enable ESLint for dom/base/test/chrome (automatic changes)

Comment 3

[mordax]

Attachment: Bug 1508983 - Enable ESLint for dom/base/test/chrome/ (manual changes)

Depends on D13128

Comment 4

[mordax]

Attachment: Bug 1508983 - Enable ESLint for dom/base/test/unit (automatic changes)

Depends on D13129

Comment 5

[mordax]

Attachment: Bug 1508983 - Enable ESLint for dom/base/test/unit (manual changes)

Depends on D13130

Comment 6

[mordax]

Sorry for the awkward, tacked on extra bug number, I did the "-b 1508983" appending in moz-phab out of worry that it wouldn't pick up on the # before the number. Any way to remove it?

Comment 7

[Mark Banner (:standard8)]

(In reply to mordax from comment #6)
> Sorry for the awkward, tacked on extra bug number, I did the "-b 1508983"
> appending in moz-phab out of worry that it wouldn't pick up on the # before
> the number. Any way to remove it?

When you do your next update, if you use `hg histedit` you can use the "mess" (m) option to change the message for each commit. Generally just make the commit message "Bug 1508983 - Enable ESLint for dom/base/test/unit (manual changes)" with no #.

Once you've done the changes, you should be able to run `moz-phab submit` again and it'll update the titles for you. If you're not using moz-phab, then just go into the revisions on phabricator and select "Edit Revision", from there you can change it.

Comment 8

[mordax]

Attachment: Bug 1508983 - Enable ESLint for dom/base/test/chrome/ (Fixing up previous manual changes)

Depends on D13134

Comment 9

[Andrew McCreight [:mccr8]]

I'm on PTO so you'll get faster reviews from somebody else.

Comment 10

[Mark Banner (:standard8)]

Ok, thanks Andrew.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/002907f3b577
Enable ESLint for dom/base/test/chrome (automatic changes) r=Standard8,smaug
https://hg.mozilla.org/integration/autoland/rev/61192787a882
Enable ESLint for dom/base/test/chrome/ (manual changes) r=Standard8,smaug
https://hg.mozilla.org/integration/autoland/rev/dd6e480be253
Enable ESLint for dom/base/test/unit (automatic changes) r=Standard8,mccr8
https://hg.mozilla.org/integration/autoland/rev/6b3257019239
Enable ESLint for dom/base/test/unit (manual changes) r=Standard8,smaug

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/002907f3b577
https://hg.mozilla.org/mozilla-central/rev/61192787a882
https://hg.mozilla.org/mozilla-central/rev/dd6e480be253
https://hg.mozilla.org/mozilla-central/rev/6b3257019239

Comment 13

[Mark Banner (:standard8)]

This has now landed on the main branch. Mordax, thank you for working on this.

Comment 14

[mordax]

(In reply to Mark Banner (:standard8) from comment #13)
> This has now landed on the main branch. Mordax, thank you for working on
> this.

No, thank you! Sorry for the lack of banter, I've been like the living dead these few days due to the end of my semester. Thanks for your direction and really helpful reviews, I'm glad you were our mentor! I'll be sticking around if you folks don't mind, this was a really enjoyable experience!