Closed
Bug 1508988
Opened 6 years ago
Closed 5 years ago
Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla66
People
(Reporter: standard8, Assigned: jrkong.hfd)
References
Details
(Whiteboard: [seneca-eslint])
Attachments
(2 files)
As part of rolling out ESLint across the tree, we should enable it for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/.
|
||
Updated•6 years ago
|
Priority: -- → P3
Hey Mark, I'll take a look at this issue! I'd appreciate it if you can assign it to me.
|
Reporter | |
Updated•6 years ago
|
Assignee: standard8 → jrkong.hfd
|
|
Reporter | |
Comment 4•5 years ago
|
||
Alex, I've just realised there's no author information on these commits so we can't land them automatically. You'll need to do something like this: $ hg histedit <select to edit the first commit> $ hg commit --amend --author "Alex Kong <myemail@example.com>" $ hg histedit --continue $ hg commit --amend --author "Alex Kong <myemail@example.com>" $ moz-phab submit That should provide the correct author information on the commits. You can see this if you go to one of the revisions in Phabricator, and look for the "Revision Contents" table, and under the "Commits" tab there is an author column.
Flags: needinfo?(jrkong.hfd)
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b15b5b6dbce2 Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (automatic changes). r=Standard8,nika https://hg.mozilla.org/integration/autoland/rev/2326b807ec86 Enable ESLint for dom/abort/, dom/asmjscache/, dom/battery/, dom/broadcastchannel/ and dom/console/ (manual changes). r=Standard8,nika
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b15b5b6dbce2 https://hg.mozilla.org/mozilla-central/rev/2326b807ec86
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
|
Reporter | |
Updated•5 years ago
|
Flags: needinfo?(jrkong.hfd)
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•