150901 - Some params containing mail-templates contain URLs with terminating punctuation

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Gervase Markham [:gerv]]

Some mailers are not smart enough to correctly linkify:

Use the Bugzilla Helper to submit bugs:
http://www.mozilla.org/quality/help/bug-form.html.

and linkify the trailing period. We should add spaces before any trailing
periods. This is definitely a problem on b.m.o's customised version (where I got
the original report from - thanks to [e-mail]), and may also be a problem
in the trunk.

Gerv

Comment 1

[Shane H. W. Travis]

I only see one place where there is punctuation after a URL in the trunk, and 
that's in the default 'whinemail' parameter. 

I will fix this for the trunk; am setting the bug to block the bmo-upgrade bug 
so that Dave knows to check for this issue in customized bmo templates the next 
time he updates.

Comment 2

[Shane H. W. Travis]

Attachment: Code patch for tip

About as simple as a patche can be...

Comment 3

[Dave Miller [:justdave]]

OK, this doesn't appear to be an issue on bmo currently except for the one
travis found.  The URL to the Bugzilla Helper changed, and the period was
removed when the link was changed in the password mail.

Comment 4

[Shane H. W. Travis]

[14:02] <travis> 150901 was, perhaps, the simplest bugfix I shall ever do: 
[14:02] <travis> I removed one period from one line of code.
[14:02] <travis> (Is there a category below 'trivial'?)

Checking in defparams.pl;
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.148; previous revision: 1.147
done