Closed
Bug 1509010
Opened 5 years ago
Closed 5 years ago
Fix some clang-format comment issues in js/public
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla65
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
16.74 KB,
patch
|
lizzard
:
approval-mozilla-esr60+
|
Details | Diff | Splinter Review |
Minor fixes for places where clang-format messes up. Very similar to what bug 1508255 did for js/src.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/834b61114235 Fix some clang-format comment issues in js/public. r=tcampbell
Comment 3•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/834b61114235
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 4•5 years ago
|
||
[ESR Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format. User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future. Fix Landed on Version: 65 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Comment only change that has baked on trunk for a while String or UUID changes made by this patch: None
Attachment #9030998 -
Flags: approval-mozilla-esr60?
Updated•5 years ago
|
status-firefox-esr60:
--- → affected
Comment 5•5 years ago
|
||
Comment on attachment 9030998 [details] [diff] [review] ESR patch OK for uplift to ESR60 as part of the clang-format project.
Attachment #9030998 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Comment 6•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/beb58228e1a5
You need to log in
before you can comment on or make changes to this bug.
Description
•