1509459 - Highlighter toggle in wrong state when layout panel hasn't been opened

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: flex-toggle.mp4

STR:
- open a website containing flexbox elements
- open the inspector, without the layout panel being on by default
- highlight a flex container through the rules panel
- switch to the layout panel

ER:
- the toggle for the flex highlighter should be enabled

AR:
- the toggle for the flex highlighter is disabled


See video attached

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1509459.patch [1.0]

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfb51d413370
Get the flexbox highlighter state if the highlighter is ready in the flexbox panel. r=pbro

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out changeset cfb51d413370 (Bug 1509459) for devtools failures on browser_flexbox_highlighter_color_picker_on_ESC.js.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/037b1d961ac53610890b6cb3dcc6ac81ad7ce008

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=cfb51d413370736adc5200b42598564d7ac2d59b&selectedJob=214411771

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214411771&repo=mozilla-inbound&lineNumber=1686

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f0794724871
Get the flexbox highlighter state if the highlighter is ready in the flexbox panel. r=pbro

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 0f0794724871 (Bug 1509459) for clipboard failures browser_styleinspector_context-menu-copy-color_02.js.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/94ef0a404e408ff3cf2b66f3de6aa9605d9a5a25

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=0f07947248713c9c5f43904fbcb7d73d2d3fb278&selectedJob=214976655

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214976655&repo=mozilla-inbound&lineNumber=3318

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a7d0cec00a3
Get the flexbox highlighter state if the highlighter is ready in the flexbox panel. r=pbro

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7a7d0cec00a3

Comment 8

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using 65.0a1(2018-11-23), on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 65.0b11 on Windows 10 x64, macOS 10.13 and Ubuntu 16.04 LTS.
Cheers!