Closed
Bug 1510174
Opened 6 years ago
Closed 6 years ago
Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture()
Categories
(Core :: Graphics: WebRender, defect, P2)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
By accident, I set wrong WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() in Bug 1499255, though during testing, I used correct value. WrExternalImageBufferType should be WrExternalImageBufferType::TextureExternalHandle here.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
Summary: Fix Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() → Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture()
|
|
Assignee | |
Updated•6 years ago
|
Blocks: wr-android
|
|
Assignee | |
Comment 1•6 years ago
|
||
It caused the following error during using SurfaceTexture.
> E webrender::device::gl: Failed to compile shader: brush_image
> E webrender::device::gl: ERROR: 0:190: 'sampler2DRect' : Reserved word.
> E webrender::device::gl: ERROR: 0:190: 'sampler2DRect' : Syntax error: syntax error
> E webrender::device::gl: INTERNAL ERROR: no main() function!
> E webrender::device::gl: ERROR: 2 compilation errors. No code generated.
> E webrender::device::gl:|
|
Assignee | |
Comment 2•6 years ago
|
||
By accident, WrExternalImageBufferType::TextureRectHandle was set in SurfaceTextureHost::CreateRenderTexture() instead of WrExternalImageBufferType::TextureExternalHandle in Bug 1499255.
|
||
Updated•6 years ago
|
Attachment #9027838 -
Attachment description: Bug 1510174 - Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() → Bug 1510174 - Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() r?nical
|
||
Updated•6 years ago
|
Priority: -- → P2
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1e338cf25fc3 Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() r=kats
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1e338cf25fc3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•