Closed
Bug 1510654
Opened 6 years ago
Closed 5 years ago
[remote-dbg-next] Remove usage of client.request() for service workers
Categories
(DevTools :: about:debugging, enhancement, P1)
DevTools
about:debugging
Tracking
(firefox66 fixed)
RESOLVED
FIXED
Firefox 66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 3 open bugs)
Details
Attachments
(7 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
We should cleanup all the call sites in about:debugging that still rely on client.request: https://searchfox.org/mozilla-central/search?q=clientWrapper.request&case=false®exp=false&path= Instead to be consistent, we should get a front for the service worker and call methods on it.
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P3 → P1
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D15374
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D15375
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D15376
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D15377
Assignee | ||
Comment 6•5 years ago
|
||
Green try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a8dd2c3042d93a76fd10e928b77ea1e3d124979
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D15378. This is an additional cleanup I forgot to include in the earlier patches. We no longer use the request API in about:debugging so we can remove it from our wrapper.
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ca78d645eed Extract ServiceWorkerRegistrationList from worker-list.js;r=ochameau,ladybenko https://hg.mozilla.org/integration/autoland/rev/2ecae1ee43a0 Move worker/worker-list.js to targets/worker-list;r=ochameau,ladybenko https://hg.mozilla.org/integration/autoland/rev/a2289d2698b7 Create fronts for ServiceWorkerRegistration, PushSubscription and ServiceWorker;r=ochameau,ladybenko https://hg.mozilla.org/integration/autoland/rev/247e6818b262 Return ServiceWorker fronts for installing, active and waiting workers;r=ochameau,ladybenko https://hg.mozilla.org/integration/autoland/rev/08b043c4ef1b Extract service worker actors to dedicated files;r=ochameau,ladybenko https://hg.mozilla.org/integration/autoland/rev/ab1bfb032425 Remove request API from client wrapper;r=ladybenko
Assignee | ||
Comment 9•5 years ago
|
||
Depends on D16022 . Minor fix, just reordering a spec definition.
Comment 10•5 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/639924062722 Reorder specs to be alphabetically sorted;
Comment 11•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8ca78d645eed
https://hg.mozilla.org/mozilla-central/rev/2ecae1ee43a0
https://hg.mozilla.org/mozilla-central/rev/a2289d2698b7
https://hg.mozilla.org/mozilla-central/rev/247e6818b262
https://hg.mozilla.org/mozilla-central/rev/08b043c4ef1b
https://hg.mozilla.org/mozilla-central/rev/ab1bfb032425
https://hg.mozilla.org/mozilla-central/rev/639924062722
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•