1510797 - Update about:Webrtc to use Fluent

Status: RESOLVED FIXED

(Toolkit :: General, defect, P3)

Description

[Jim Lennon [:jim]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:63.0) Gecko/20100101 Firefox/63.0

Comment 1

[Jim Lennon [:jim]]

Migrate strings currently in aboutWebrtc.properties to aboutWebrtc.ftl and update references as necessary.

Comment 2

[Dan Minor [:dminor]]

I'm planning to work on this as a way of learning fluent.

Comment 3

[Dan Minor [:dminor]]

Setting the intl.l10n.pseudo pref to accented is a good way of testing for unlocalized strings.

Comment 4

[Dan Minor [:dminor]]

Initial try run here: https://treeherder.mozilla.org/jobs?repo=try&revision=9b38ca472a339f1b93d3f225334d0267b288ed0f. Please note there are no unit tests currently written for about:webrtc.

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1510797 - Migrate about:webrtc to Fluent; r=ng!

Comment 6

[Dan Minor [:dminor]]

Try run here: https://treeherder.mozilla.org/jobs?repo=try&revision=bd24f7a8a5898dd80706fb37c1b3a469c83c3378

Comment 7

[Dan Minor [:dminor]]

I also ran browser/base/content/test/static/browser_misused_characters_in_strings.js locally, hopefully that is sufficient.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83962006724b
Migrate about:webrtc to Fluent; r=ng,flod

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/83962006724b