Closed
Bug 1512286
Opened 5 years ago
Closed 5 years ago
Run windows10 AWSY on virtual-with-gpu
Categories
(Testing :: AWSY, defect)
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(5 files)
Right now non-webrender AWSY runs on a VM without a GPU, which measures an unaccelerated experience. This is hard to compare apples-to-apples with WebRender, which requires a GPU. In bug 1509974 comment 5, I proposed moving the existing windows10 AWSY tests to virtual-with-gpu, so that we have have a comparable baseline. https://treeherder.mozilla.org/#/jobs?repo=try&revision=e10637044bdceb089ea26fbb2f6b38c8c5e2fcb1
Assignee | ||
Comment 1•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=639cfcee65d14c53aa56fd10c9535e1c7f4beeba
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D13963
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D13964
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e1b3f3624b87 Support an environmental variable to force-disable WebRender. r=kats https://hg.mozilla.org/integration/autoland/rev/929fe0acd506 Use the env var on non-QR platforms. r=kats https://hg.mozilla.org/integration/autoland/rev/cd601d93d9f3 Force non-QR onto virtual-with-gpu. r=kats
Comment 6•5 years ago
|
||
Backed out 3 changesets (bug 1512286)for breaking test because of missing option push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=215924245&revision=cd601d93d9f39d7ec1194d77686db1984a2ee708 failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=215925650&searchStr=os%2Cx%2C10.10%2Cdebug%2Ctest-macosx64%2Fdebug-gtest%2C%28gtest%29 backout: https://hg.mozilla.org/integration/autoland/rev/5ae509e2f3b638ca15e14cad8441a3cf75ad4647
Flags: needinfo?(bobbyholley)
Assignee | ||
Comment 7•5 years ago
|
||
Try push for the fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=02c04d621c19661ee8235629e02e9cba593d561a
Flags: needinfo?(bobbyholley)
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47035a397239 Support an environmental variable to force-disable WebRender. r=kats https://hg.mozilla.org/integration/autoland/rev/4d90a83e78cf Use the env var on non-QR platforms. r=kats https://hg.mozilla.org/integration/autoland/rev/1c9251fcdc67 Force non-QR onto virtual-with-gpu. r=kats
Assignee | ||
Comment 9•5 years ago
|
||
Here's a before-after comparison on memory: https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=639cfcee65d14c53aa56fd10c9535e1c7f4beeba&framework=4&filter=windows10&showOnlyComparable=1&selectedTimeRange=172800 Explicit is mostly unchanged, and Resident gets significantly worse. This almost certainly corresponds to VirtualAlloc calls in the graphics driver, which is exactly what we'd expect here. Comparison of memory reports shows the increase primarily coming in increases in commit/private/readwrites{,+writecombine}, which also supports this theory. So we should expect a ~18.5% regression in AWSY resident, and treat it as a baseline update. Eric, can you acknowledge?
Flags: needinfo?(erahm)
Assignee | ||
Comment 10•5 years ago
|
||
Assignee | ||
Comment 11•5 years ago
|
||
Attaching some before/after memory reports for comparison.
Comment 12•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/47035a397239 https://hg.mozilla.org/mozilla-central/rev/4d90a83e78cf https://hg.mozilla.org/mozilla-central/rev/1c9251fcdc67
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 13•5 years ago
|
||
(In reply to Bobby Holley (:bholley) from comment #9) > Here's a before-after comparison on memory: > https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla- > central&newProject=try&newRevision=639cfcee65d14c53aa56fd10c9535e1c7f4beeba&f > ramework=4&filter=windows10&showOnlyComparable=1&selectedTimeRange=172800 > > Explicit is mostly unchanged, and Resident gets significantly worse. This > almost certainly corresponds to VirtualAlloc calls in the graphics driver, > which is exactly what we'd expect here. Comparison of memory reports shows > the increase primarily coming in increases in > commit/private/readwrites{,+writecombine}, which also supports this theory. > > So we should expect a ~18.5% regression in AWSY resident, and treat it as a > baseline update. Eric, can you acknowledge? No surprises after landing, thanks for testing ahead of time.
Flags: needinfo?(erahm)
You need to log in
before you can comment on or make changes to this bug.
Description
•