Closed Bug 1512489 Opened 6 years ago Closed 5 years ago

Convert datetime-popup to a lazily loaded JSM

Categories

(Toolkit :: UI Widgets, task, P3)

Product:
Toolkit
Component:
UI Widgets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

Attachments

(1 file)

Bug 1512489 - Convert datetime-popup binding to a JSM
47 bytes, text/x-phabricator-request
Details | Review 
The only user of datetime-popup implementation is DateTimePickerParent.jsm -- change the caller there will allow us to convert it to another JSM or a custom element.

We couldn't simplify this by merging it to DateTimePickerParent.jsm [1]; it init()s in BrowserGlue._onFirstWindowLoaded().

[1] https://searchfox.org/mozilla-central/rev/adec563403271e78d1a057259b3e17fe557dfd91/browser/components/nsBrowserGlue.js#1355
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #0)
> We couldn't simplify this by merging it to DateTimePickerParent.jsm [1]; it
> init()s in BrowserGlue._onFirstWindowLoaded().

Well, perhaps that's not really a problem given there are only a few hundred lines, not thousands.
Component: XBL → XUL Widgets
Product: Core → Toolkit
I've got a patch!
Assignee: nobody → timdream
Status: NEW → ASSIGNED
See Also: → 1423498
Summary: Convert datetime-popup to a lazily loaded custom element → Convert datetime-popup to a lazily loaded JSM
Priority: -- → P3
Pushed by tchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c41d930784a8
Convert datetime-popup binding to a JSM r=Felipe
https://hg.mozilla.org/mozilla-central/rev/c41d930784a8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Depends on: 1522779
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: