1513181 - Mozmill failure on 2018-12-11: 3 failing tests, Mac failure only: testEventDialog.js, testEventDialogModificationPrompt.js, testUTF8.js

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1513110 +++

TEST-UNEXPECTED-FAIL | [snip]/mozmill/eventDialog/testEventDialog.js | testEventDialog.js::testEventDialog
TEST-UNEXPECTED-FAIL | [snip]/mozmill/eventDialog/testEventDialogModificationPrompt.js | testEventDialogModificationPrompt.js::testEventDialogModificationPrompt
TEST-UNEXPECTED-FAIL | [snip]/mozmill/eventDialog/testUTF8.js | testUTF8.js::testUTF8

M-C last good: 68151063d1c63ce445d67aa743a018d7f6
M-C first bad: 13f891b92db19ea8ec85ef329eff7a793c
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=68151063d1c63ce445d67aa743a018d7f6&tochange=13f891b92db19ea8ec85ef329eff7a793c

Geoff already fixed 8 failing tests in bug 1513110. So for these failures the log
https://taskcluster-artifacts.net/IUKQSg8NQuWooshuXuE06A/0/public/logs/live_backing.log
says things like:

SUMMARY-UNEXPECTED-FAIL | testEventDialog.js | testEventDialog.js::testEventDialog
EXCEPTION: waitFor: Timeout exceeded for '() => !eventid("status-privacy-private-box").getNode().hasAttribute("collapsed")'

SUMMARY-UNEXPECTED-FAIL | testEventDialogModificationPrompt.js | testEventDialogModificationPrompt.js::testEventDialogModificationPrompt
EXCEPTION: Checkbox ID: event-all-day could not be checked/unchecked

SUMMARY-UNEXPECTED-FAIL | testUTF8.js | testUTF8.js::testUTF8
EXCEPTION: could not validate element ID: item-description with value  💣 💥  ☣

Comment 1

[Jorg K (CEST = GMT+2)]

Could someone with a Mac please check out what's happening here. Maybe the screenshot facility helps.

Comment 2

[Geoff Lankow (:darktrojan)]

Just made a Try push with screenshots enabled. Will see if that helps.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0214102d2c62ef296fa2d33ed22305f40aab8444

Comment 3

[Geoff Lankow (:darktrojan)]

I think there's some timing issue here. In this screenshot, the first three letters typed are missing:

https://taskcluster-artifacts.net/EtQJgYNORzWe8V6hC7LtkA/0/public/test_info/testEventDialogModificationPrompt.js__testEventDialogModificationPrompt-pdpudM.png

In this one, we should've opened a popup and clicked on a value, but it hasn't happened:

https://taskcluster-artifacts.net/EtQJgYNORzWe8V6hC7LtkA/0/public/test_info/testEventDialog.js__testEventDialog-DHtEmP.png

(Side note, why is the default privacy set to confidential on Mac but on my Linux box confidential isn't even an option?)

Comment 4

[Geoff Lankow (:darktrojan)]

The "category" and "until" boxes are also wrong in testEventDialog.js. What the heck is going on?

Comment 5

[Intermittent Failures Robot]

2 failures in 2485 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* comm-central: 2

Platform breakdown:
* osx-10-10: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1513181&startday=2018-12-10&endday=2018-12-16&tree=all

Comment 6

[Arshad Khan [:arshad]]

Attachment: Screenshot 2018-12-17 at 9.11.09 PM.png

the dropdown button is missing for event dialog, maybe it might be the reason behind some of the failures.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1513181-menulist-dropmarker.patch

I can't find which bug regressed this, but I think it was a de-XBL bug which changed the menulist[editable="true"].

I'm asking you because you are on a Mac and it also affects Calendar the time link images in event dialog.

It's also a bit of a UI review as the native menulist does no more work and I show the dropmarker like on Windows. Can a Mac user work like this?

I started also a try to check if it fixes the Mac test failures: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=374780427fd8457008c4219d074c7fee5956b912

Comment 8

[Richard Marti (:Paenglab)]

Hmm, the failures are still there. :-(

Comment 9

[Geoff Lankow (:darktrojan)]

While this is being looked at I'd like these extra checks to be added:

https://hg.mozilla.org/try-comm-central/rev/7cd9254c77a5bb1fb11c0d24d83d9d730f796d89

There's probably some more things that need checking too.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f9cf0cecc60c
disable three failing tests on Mac. rs=bustage-fix

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I've debugged into this test to start:

SUMMARY-UNEXPECTED-FAIL | testEventDialog.js | testEventDialog.js::testEventDialog
EXCEPTION: waitFor: Timeout exceeded for '() => !eventid("status-privacy-private-box").getNode().hasAttribute("collapsed")'

The issue is that the private item is not actually selected by setData. If I comment out the line that attempts to close the popup, then I get past this step.

Maybe this is a pointer for someone to continue, I may have time later for more.

Comment 12

[Richard Marti (:Paenglab)]

Comment on attachment 9031951 [details] [diff] [review]
1513181-menulist-dropmarker.patch

Moved this patch to a new bug 1519664 as it isn't the fix for the failures.

Comment 13

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This should help. setData was not setting all the fields, mostly because the popups were not closed properly. I've run the other mentioned tests and they magically work for me, so maybe it was related.

Comment 14

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Joint try run here, hope it works: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=972146ac4632d9dbd08f14ad2b4b362cdc9ed66e

Comment 15

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 9036197 [details] [diff] [review]
Fix - v1

I did a try run that really works, but it seems testUTF8 is failing. Back to the drawing board.

Comment 16

[Jorg K (CEST = GMT+2)]

Philipp, any cycles for this? I see the tests are still disabled on Mac.

Comment 17

[ISHIKAWA, Chiaki]

Actually, this error occurs for linux64, too.
See linux64 debug mozmill test, Z4 failure in the following job:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1efef0618b93807f236e72ddfab797b19023b6d1&selectedJob=256145952

Comment 18

[ISHIKAWA, Chiaki]

(In reply to ISHIKAWA, Chiaki from comment #17)

Actually, this error occurs for linux64, too.
See linux64 debug mozmill test, Z4 failure in the following job:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1efef0618b93807f236e72ddfab797b19023b6d1&selectedJob=256145952

There are so many assertion failures of the form
Constructing RangeBoundary with invalid value: 'mRef || aOffset == 0', file /builds/worker/workspace/build/src/obj-thunderbird/dist/include/mozilla/RangeBoundary.h, line 79
during the execution of this test that I think something is wrong with the test or the TB code.

BTW, how do we run this test locally? TB's |make mozmill| does not seem to invoke this test locally at all...

Comment 19

[Jorg K (CEST = GMT+2)]

mozmake -C comm/calendar/test/mozmill SOLO_TEST=eventDialog/testEventDialog.js mozmill-one

Comment 20

[Geoff Lankow (:darktrojan)]

Fixed, or at least re-enabled and working again, by bug 1585162.