1513325 - Remove textbox binding

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Tim Nguyen :ntim]

I believe the textboxes don't provide more features than html input, most of the code in the textbox binding serves to forward attributes/events to the inner html input.

The only thing I would be worried about would be the "Edit" context menu. It seems to be working automatically for HTML inputs when used in-content (even in XUL docs), I'm simply not sure whether it works in the top-level browser window, hence the suggestion to start only with the in-content ones.

Comment 1

[Tim Nguyen :ntim]

For the top-level browser window, if the context menu turns out not to work, it should be possible to use a customized built-in HTML input like bug 1437641 is doing.

Comment 2

[Tim Nguyen :ntim]

Now that the context menu stuff has been sorted out by bgrins (thanks!). Here’s a tentative plan:

• make autocomplete and search-textbox independent from textbox
• wait for quantumbar and remove legacy-urlbar
• fold searchbar-textbox with the searchbar CE
• fold urlbar behavior with UrlbarInput
• convert all normal textboxes to input

Comment 3

[Tim Nguyen :ntim]

Shorter plan to remove all the textbox bindings requiring less effort:

• Fix bug 1521280
• Wait for quantumbar and remove legacy-urlbar
• Fix bug 1513337
• Fix bug 1534404
• Convert all <textbox> (except type="autocomplete") to <input>
• Convert autocomplete to CE

Comment 4

[Tim Nguyen :ntim]

Attachment: Bug 1513325 - Remove textbox binding.

Comment 5

[Emma Malysz]

Attachment: Bug 1513325, modify tests that previously used textbox elements

Comment 6

[Tim Nguyen :ntim]

Hi Emilio, panel/arrowpanel is getting removed in bug 1397876, which means textbox will be the last binding to be removed. 🎉

I was however wondering what to do with the ‘MayNeedToLoadXBLBinding’ function. Not sure how conservative we are at removing the XBL platform code (for the unlikely event that we want to restore an XBL binding), but the simplest option would be to replace the ‘if (!aElement.IsAnyOfXULElements(nsGkAtoms::textbox)) {‘ check with ‘if (true)’, but may as well remove all the related code in this case.

Would you be OK with removing MayNeedToLoadXBLBinding and the related code? If so, is this something you can provide a patch for?

Comment 7

[Brian Grinstead [:bgrins]]

(In reply to Tim Nguyen :ntim from comment #6)

Hi Emilio, panel/arrowpanel is getting removed in bug 1397876, which means textbox will be the last binding to be removed. 🎉

I was however wondering what to do with the ‘MayNeedToLoadXBLBinding’ function. Not sure how conservative we are at removing the XBL platform code (for the unlikely event that we want to restore an XBL binding), but the simplest option would be to replace the ‘if (!aElement.IsAnyOfXULElements(nsGkAtoms::textbox)) {‘ check with ‘if (true)’, but may as well remove all the related code in this case.

Would you be OK with removing MayNeedToLoadXBLBinding and the related code? If so, is this something you can provide a patch for?

If Emilio is fine with it, I'd prefer to make that function just return false in this patch, with a comment pointing to Bug 1585823 for removal. I suspect there's a bit of cleanup to follow on with and would rather do it in a separate bug.

Comment 8

[Tim Nguyen :ntim]

(This comment wasn't meant to be posted)

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Yeah, let's do that, or just not touch that function at all and I'll get rid of it in that bug.

Comment 10

[Tim Nguyen :ntim]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=205b2f9cfc370388089a33e519fec7601fd0a2c8

Comment 11

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5718c58bcd6dea81ab17e3e3ff80b47ade9431d

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59f0469f5a48
Remove textbox binding. r=emilio,dao

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

There is one failure on Windows AArch left: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Csuperseded%2Cretry%2Cusercancel&searchStr=windows%2Caarch&revision=59f0469f5a486ddea7543100b3f335706b072955

Comment 14

[Tim Nguyen :ntim]

Attachment: Bug 1513325 - Remove some a11y tests that no longer apply in a post-XBL world.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/733589091613
Remove some a11y tests that no longer apply in a post-XBL world. r=aryx

Comment 16

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/59f0469f5a48

Comment 17

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/733589091613