1514715 - Update color prefs to allow customizing Windows 10 titlebar accent color

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Kestrel]

Since Bug 1503306 has applied the Windows 10 accent color to all built-in themes it would be nice to be able to alter it with a pref. This would normally be possible with nsXPLookAndFeel::sColorPrefs but Bug 1344910 did not update it to include the new accent color IDs.

> ui.-moz-win-accentcolor
> ui.-moz-win-accentcolortext

Comment 1

[Kestrel]

Attachment: Bug 1514715 - Update color prefs for new color IDs including -moz-win-accentcolor

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Hi Jim, can you please look at the review request for this when you get a chance? We've only got a couple weeks left for uplifting patches for 65 before it goes to RC.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34d4a5081960
Update color prefs for new color IDs including -moz-win-accentcolor r=jmathies

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/34d4a5081960

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 6

[Kestrel]

Comment on attachment 9031827 [details]
Bug 1514715 - Update color prefs for new color IDs including -moz-win-accentcolor

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1503306

User impact if declined: User can no longer disable/control the titlebar accent color for the built-in themes independently of the OS setting.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Only adds three additional hidden color preferences that do nothing unless the user manually creates them.

String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9031827 [details]
Bug 1514715 - Update color prefs for new color IDs including -moz-win-accentcolor

[Triage Comment]
Allows users to modify the accent color of the titlebar for built-in themes independent of the OS setting. Approved for 65.0b11.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/192563fa8623