1514975 - No mousemove (mouseover, mouseenter) events before contextmenu event caused by long tap

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

1. Load https://d-toybox.com/studio/lib/pointing_device_event_viewer.html with Firefox for Android
2. Long tap in red-dashed-border area.

Actual result:
touchstart -> contextmenu -> touchmove -> touchend

Chrome's result:
touchstart -> mouseover -> mouseenter -> mousemove -> contextmenu -> touchend

I think that like normal tap, we should synthesize mousemove event before dispatching contextmenu event. Then, Firefox for Android users can open submenu which is opened when hover a link with long tap.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc55ef33d69388c302685e9613861dd03eb3308d

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=db5588c9ebcad8c68a0748c3b8055ee75d64d81d

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d7f3fec5c5d0a1df5ba83c8505ea526335790bc

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1514975 - Synthesize mousemove event before contextmenu event caused by long tap

Chrome synthesizes mousemove event and related events (mouseover, mouseenter,
etc) when context menu event is fired by long tap.  This allows users to open
submenu which is opened by moving mouse cursor over a link.

So, this fix improves accessibility of our users on some websites which are
designed for desktop.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=46b74c7cbfa7f715462b669fa6d13e7da777857a

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0d868d4fa6a662fd0f7709859e9214bb45b1480

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6cb83470c9dcd6277b80d2c15ce5fbbe50b232d

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 9032139 [details]
Bug 1514975 - Synthesize mousemove event before contextmenu event caused by long tap

Perhaps, dropped from your review queue.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

yup, didn't see in the queue. looking.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Ah, were the reviewers optional, so when kats had reviewed this, this was gone from my queue.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72fc38d3a04ebc48b83e064d14769748a10191c6

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7cdebc2452822db7cfc0e5d18ce6d45b13d20982

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bd1a8ffe4a9
Synthesize mousemove event before contextmenu event caused by long tap r=smaug,kats

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] from comment #10)

Ah, were the reviewers optional, so when kats had reviewed this, this was gone from my queue.

Oh, I understand. So, sounds like that we should request review to module owner or peer as "blocking". Otherwise, any review requests may be canceled silently.

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3bd1a8ffe4a9