Closed
Bug 1515081
Opened 5 years ago
Closed 5 years ago
Re-implement autocomplete 1st/6 entries timing telemetry for on the new QuantumBar
Categories
(Firefox :: Address Bar, enhancement, P1)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [fxsearch])
Attachments
(2 files)
|
Bug 1515081 - Fix the cancel search test for the UrlbarController to actually test the cancel. r?mak
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
As part of the work for the new QuantumBar, we should ensure that the telemetry probes PLACES_AUTOCOMPLETE_1ST_RESULT_TIME_MS and PLACES_AUTOCOMPLETE_6_FIRST_RESULTS_TIME_MS continue working. These are probes for the amount of time it takes to get the first result, and then the amount of time for the first six results.
|
Assignee | |
Updated•5 years ago
|
Summary: Re-implement telemetry for Autocomplete 1st/6 entries on the new QuantumBar → Re-implement autocomplete 1st/6 entries timing telemetry for on the new QuantumBar
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Priority: P2 → P1
|
|
Assignee | |
Comment 2•5 years ago
|
||
Note: for now, I've gone for these being defined in the controller. As we add more, we can decide if it makes sense for a separate module or not.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Currently, it only passes that test due to awaiting for a non-promise.
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D15817
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5747fe4edb8a Fix the cancel search test for the UrlbarController to actually test the cancel. r=mak https://hg.mozilla.org/integration/autoland/rev/068f7beef2c8 Reimplement autocomplete result timing telemetry for the new quantumbar. r=mak
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5747fe4edb8a
https://hg.mozilla.org/mozilla-central/rev/068f7beef2c8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•