1515197 - Consider removing the window length setting from the perf panel

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

Description

[Markus Stange [:mstange]]

The performance panel is not designed for a continuous profiling workflow. It's designed for the "start profiling, do something, stop profiling" workflow.

However, currently we also have a setting for the fixed time window length in the panel, and it defaults to 20 seconds. I think we should consider removing this setting, or at least initializing it with "infinity", so that we don't accidentally cut off people's recordings.

The fixed time window setting is really only intended for the "continuous profiling" workflow. The few people that use this workflow use it through the Gecko Profiler add-on, not through the devtools performance panel.

Comment 1

[Julien Wajsberg [:julienw]]

I'm fine defaulting to Infinity for this, the reasoning makes sense to me. Nazim, what do you think?

Aaaaah we spent so much time polishing the actor/client mechanism to do this properly :-)

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Yeah, it also makes sense to me. I can make it default to Infinity and remove the setting from panel.

Heh, yeah it took a while to make actor/client mechanishm :)

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1515197 - Remove the window length setting from devtools performance panel r?julienw

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1515197 - Remove the "max" from "Max buffer size" label since it's not resizable anymore r?julienw

We made the profiler buffer resizable before that patch but then we decided that
it's not a good idea to do since we are spending so much time to allocate memory.
Since buffer size is constant, we don't need to add "max" anymore.

Depends on D15655

Comment 5

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Try job: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3eea5f6297c9148e6adb50aff44bea1ddf76353b (fixed the ES lint warning)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27dc3484e7ef
Remove the window length setting from devtools performance panel r=julienw
https://hg.mozilla.org/integration/autoland/rev/f46ff2feaf5f
Remove the "max" from "Max buffer size" label since it's not resizable anymore r=julienw

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/27dc3484e7ef
https://hg.mozilla.org/mozilla-central/rev/f46ff2feaf5f