1517753 - currency-amount.js is a javascript module and shouldn't define "use strict";

Status: RESOLVED FIXED

(Firefox :: WebPayments UI, enhancement, P5)

Description

[Mark Banner (:standard8)]

currency-amount.js is a javascript module and shouldn't define "use strict"

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode#Strict_mode_for_modules

https://searchfox.org/mozilla-central/search?q=currency-amount.js&case=true&regexp=false&path=

We should drop that statement as it is redundant.

I'm happy to mentor this.

Comment 1

[matthewacha]

Hey @standard8,
I would like to work on this bug, however, I would like you to know that this is my first time to contribute here and need some guidance on setup.

Comment 2

[Mark Banner (:standard8)]

Hi, to get set up, follow the steps here:

https://developer.mozilla.org/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build

Note that you probably don't need to do a build here, but creating one won't hurt. When you get to the './mach bootstrap' step, select the 'artifact' mode.

Once you've got the source, and created a patch, create a commit using this title: 'Bug 1517753 - currency-amount.js is a javascript module and shouldn't define "use strict" r?Standard8'

You can the submit it to phabricator for review:

https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Note: use the "moz-phab" submission method, rather than the arcanist one.

If you need more help, you can ask in #introduction on IRC (https://wiki.mozilla.org/IRC), or ask here.

Comment 3

[matthewacha]

Ok, thanks @standard8

Comment 4

[matthewacha]

Attachment: Bug 1517753 - currency-amount.js is a javascript module and shouldn't define "use strict" r?Standard8

- Deleted 'use strict' from currency-amount.js

Comment 5

[matthewacha]

@standard8 I have worked on it. Its awaiting your review

Comment 6

[Mark Banner (:standard8)]

(In reply to matthewacha from comment #5)

@standard8 I have worked on it. Its awaiting your review

Did you see my comment here: https://phabricator.services.mozilla.com/D15960#402927 ?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff2df6d75dd4
currency-amount.js is a javascript module and shouldn't define "use strict" r=Standard8

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ff2df6d75dd4