Closed
Bug 1518098
Opened 5 years ago
Closed 5 years ago
Rename LengthOrPercentage.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(2 files)
LengthOrPercentage is a misnomer, since it represents a <length-percentage> value, not a <length> | <percentage>
|
Assignee | |
Comment 1•5 years ago
|
||
It does not represent `<length> | <percentage>`, but `<length-percentage>`, so `LengthOrPercentage` is not the right name. This patch is totally autogenerated using: rg 'LengthOrPercentage' servo | cut -d : -f 1 | sort | uniq > files for file in $(cat files); do sed -i "s#LengthOrPercentage#LengthPercentage#g" $file; done
|
|
Assignee | |
Comment 2•5 years ago
|
||
lop is not an acceptable variable name for LengthPercentage. Depends on D15812
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ca89c98ff5d Rename LengthOrPercentage to LengthPercentage. r=jwatt#style https://hg.mozilla.org/integration/autoland/rev/06c59ba512ba Manually rename some variables. r=jwatt#style
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7ca89c98ff5d https://hg.mozilla.org/mozilla-central/rev/06c59ba512ba
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Comment 5•5 years ago
|
||
https://hg.mozilla.org/projects/cedar/rev/7ca89c98ff5de65d5bef8cb3c05c336737e458ba Bug 1518098 - Rename LengthOrPercentage to LengthPercentage. r=jwatt#style https://hg.mozilla.org/projects/cedar/rev/06c59ba512bafc9e6b4830496026793998151c54 Bug 1518098 - Manually rename some variables. r=jwatt#style
You need to log in
before you can comment on or make changes to this bug.
Description
•