1518150 - import OPML feed file removes slash from title

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Thomas Seeling]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36

Steps to reproduce:

Open subscription manager for Blogs+RSS Feeds.
Add a subfolder and add RSS feed definition to that subfolder.
Example: https://www.reddit.com/r/Jokes.rss
Enter slash in title of subfolder (e.g. "/r/Jokes").
Export OPML file.
Use other instance of thunderbird (e.g. different machine) to import file.


Actual results:

Imported Feeds loose slash in titles.
Example: title is rJokes with / removed.


Expected results:

Title should be the same as when export happened.
Example: /r/Jokes.

Comment 1

[alta88]

Attachment: foldername.patch

If exported from Tb, the ompl folder display name is already clean. There's little practical risk to relaxing this restriction, and an undue penalty for legitimate names as safe disk names will be created from display names.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9038422 [details] [diff] [review]
foldername.patch

Review of attachment 9038422 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think you can assume it's a Thunderbird generated OPML file. 
Seems it works things out anyway so, r=mkmelin

Comment 3

[alta88]

of course, that's why it was overly strict to begin with.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a65a5f531d40
Don't sanitize folder names from ompl import. r=mkmelin

Comment 5

[Jorg K (CEST = GMT+2)]

You want to backport this?

Comment 6

[alta88]

why not, it's fairly risk free.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9038422 [details] [diff] [review]
foldername.patch

Not doing another TB 65 beta and the change is already in TB 66 (beta).

Comment 8

[Jorg K (CEST = GMT+2)]

TB 60.6 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/cc07422499af2dfce26d2169e11d930e2632fc0f