1519193 - Add a shadow-including tree iterator

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

This is coming up in various places in specs, and it would be nice if people didn't have to keep reimplementing it.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1519193 part 1. Add an iterator that implements "shadow-including tree order" traversal. r=emilio

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1519193 part 2. Convert CandidateFinder::Traverse to using ShadowIncludingTreeIterator. r=emilio

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1519193 part 3. Convert CustomElementRegistry::Upgrade to using ShadowIncludingTreeIterator. r=emilio

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1519193 part 4. Convert AssertNoFramesInSubtree to using ShadowIncludingTreeIterator. r=emilio

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1519193 part 5. Convert AssertNoStaleServoDataIn to using ShadowIncludingTreeIterator. r=emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aae6e06aa88b
part 1.  Add an iterator that implements "shadow-including tree order" traversal.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/1caa462e7f08
part 2.  Convert CandidateFinder::Traverse to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/08b0f2b9a96a
part 3.  Convert CustomElementRegistry::Upgrade to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/12d89a7fe296
part 4.  Convert AssertNoFramesInSubtree to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/e118466df64d
part 5.  Convert AssertNoStaleServoDataIn to using ShadowIncludingTreeIterator.  r=emilio

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 5 changesets (Bug 1519193) for build bustages in Document.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=e118466df64d23a07d2b01296c83789b93d43bfa&selectedJob=221394658

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221394658&repo=autoland&lineNumber=22095

Backout: https://hg.mozilla.org/integration/autoland/rev/487a0df75166e4bd2a4cc29d6a6e20c49997f1e9

Comment 8

[Boris Zbarsky [:bzbarsky]]

Gah, unified builds. It built locally and on try, multiple times.... Ah, well.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a5956b8ebdf
part 1.  Add an iterator that implements "shadow-including tree order" traversal.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/9edfd05acd77
part 2.  Convert CandidateFinder::Traverse to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/4a2c6e288944
part 3.  Convert CustomElementRegistry::Upgrade to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/a61568f1b081
part 4.  Convert AssertNoFramesInSubtree to using ShadowIncludingTreeIterator.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/47920e0b9643
part 5.  Convert AssertNoStaleServoDataIn to using ShadowIncludingTreeIterator.  r=emilio

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3a5956b8ebdf
https://hg.mozilla.org/mozilla-central/rev/9edfd05acd77
https://hg.mozilla.org/mozilla-central/rev/4a2c6e288944
https://hg.mozilla.org/mozilla-central/rev/a61568f1b081
https://hg.mozilla.org/mozilla-central/rev/47920e0b9643