Closed Bug 151947 Opened 22 years ago Closed 22 years ago

Make CleanupPreviousVersionRegKeys() configurable via config.ini

Categories

(SeaMonkey :: Installer, defect)

Product:
SeaMonkey
Component:
Installer
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: dprice, Assigned: dprice)

References

Details

(Whiteboard: [adt2 rtm] [ETA 06/24])

Attachments

(2 files, 4 obsolete files)

patch 2 - config changes
1.34 KB, patch
curt
: review+
dveditz
: superreview+
Details | Diff | Splinter Review
patch 3
9.89 KB, patch
dveditz
: superreview+
jud
: approval+
Details | Diff | Splinter Review 
In the netscape side of things we have registry keys under
HKLM\Software\Netscape\Netscape and HKLM\Software\Netscape\Netscape 6 

The current CleanupPreviousVersionRegKeys() is stomping on some of our newly
made keys in the Netscape 6 key because the Netscape\Netscape 6\Current version
is 6.x not 7. (that is a valid value for cases where people have side by side
installs)  

To make this flexable, we want to create a section in config.ini that looks like
this:

[Cleanup Previous Product RegKeys]
Reg Key Root=HKEY_LOCAL_MACHINE
Product Name0=Netscape
Product Reg Key0=Software\Netscape\Netscape
Current Version0=7.0b1 (en)
Product Name1=Netscape 6
Product Reg Key1=Software\Netscape\Netscape 6
Current Version1=7.0b1 (en)


see http://bugscape.netscape.com/show_bug.cgi?id=14631 for full details
Attached patch patch to the installer (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        context diff (obsolete)
        — 
          — Splinter Review
      

    


  
a context diff may be easier to read.

    
  
Keywords: nsbeta1

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch 1 - changes to config.it (obsolete)
        — 
          — Splinter Review
      

    


  

    
    

    
  
Let's make it a little more flexable so one can delete keys in different roots

This example will clean up in HKLM and HKCU

[Cleanup Previous Product RegKeys]
Reg Key Root0=HKEY_LOCAL_MACHINE
Product Name0=Mozilla
Product Reg Key0=Software\Mozilla.org\Mozilla
Current Version0=1.1 (en)
Reg Key Root1=HKEY_CURRENT_USER
Product Name0=Mozilla
Product Reg Key0=Software\Mozilla.org\Mozilla
Current Version0=1.1 (en)

Keywords: nsbeta1 → nsbeta1+
Whiteboard: [adt2 rtm

    
  
Whiteboard: [adt2 rtm → [adt2 rtm]

    
  
QA Contact: bugzilla → ktrina

    
    

    
  
Comment on attachment 87760 [details] [diff] [review]
patch 1 - changes to config.it

r=curt

        Attachment #87760 -
        Flags: review+

    
    

    
  
Comment on attachment 87750 [details] [diff] [review]
patch to the installer

r=curt

        Attachment #87750 -
        Flags: review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch 2 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #87750 -
        Attachment is obsolete: true

        Attachment #87751 -
        Attachment is obsolete: true

    
    

    
  


  

        Attachment #87760 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 88218 [details] [diff] [review]
patch 2

r=curt

        Attachment #88218 -
        Flags: review+

    
    

    
  
Comment on attachment 88219 [details] [diff] [review]
patch 2 - config changes

r=curt

        Attachment #88219 -
        Flags: review+

        Attachment #88219 -
        Flags: superreview+

    
    

    
  
Comment on attachment 88219 [details] [diff] [review]
patch 2 - config changes

sr=dveditz

mozilla.org is all lowercase

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch 3
        — 
          — Splinter Review
      

    


  

        Attachment #88218 -
        Attachment is obsolete: true

    
  
Keywords: approval, 
          
            mozilla1.0.1
Whiteboard: [adt2 rtm] → [adt2 rtm] [ETA 06/24]

    
    

    
  
Comment on attachment 88239 [details] [diff] [review]
patch 3

sr=dveditz

        Attachment #88239 -
        Flags: superreview+

    
    

    
  
on the trunk
Status: NEW → RESOLVED
Closed: 22 years ago
Keywords: adt1.0.1
Resolution: --- → FIXED

    
    

    
  
adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch, pending
drivers' approval. pls check this in asap, then add the "fixed1.0.1" keyword.
Blocks: 143047
Keywords: adt1.0.1 → adt1.0.1+

    
  

        Attachment #88239 -
        Flags: approval+

    
    

    
  
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+

    
    

    
  
on the branch
Keywords: mozilla1.0.1+ → fixed1.0.1

    
    

    
  
verified
trunk 2002070308, branch 2002070308
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.1 → verified1.0.1
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: