Closed
Bug 151978
Opened 22 years ago
Closed 22 years ago
Prebinding doesn't play well with mach-o xptcinvoke/xptcstubs implementation
Categories
(Core :: XPConnect, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: bryner, Assigned: bryner)
References
Details
Attachments
(1 file, 1 obsolete file)
|
9.65 KB,
patch
|
pavlov
:
review+
beard
:
superreview+
|
Details | Diff | Splinter Review |
If you build with prebinding enabled, and the prebinding is out of date, the app fails to start. This appears to be because some functions that are implemented in assembly reside in the data section intead of the text section. Making them reside in the text section involves using an indirect call stub. I also had to change the manner in which the method index is passed from StubNNN to SharedStub, since r12 will be clobbered by the indirect call.
|
Assignee | |
Comment 1•22 years ago
|
||
beard, pavlov, can you guys r/sr?
|
|
Assignee | |
Comment 2•22 years ago
|
||
Ok, this one is actually quite a bit less scary. I'm using m4 to generate the stub functions in the .s file.
Attachment #87774 -
Attachment is obsolete: true
|
||
Comment 3•22 years ago
|
||
Comment on attachment 88559 [details] [diff] [review] patch v2 r=pavlov looks ok to me
Attachment #88559 -
Flags: review+
|
||
Comment 4•22 years ago
|
||
Comment on attachment 88559 [details] [diff] [review] patch v2 sr=beard, looks very cool
Attachment #88559 -
Flags: superreview+
|
|
Assignee | |
Comment 5•22 years ago
|
||
Checked into the trunk and CHIMERA_M1_0_BRANCH.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Comment 6•22 years ago
|
||
Patch checkin verified on trunk and CHIMERA_M1_0_BRANCH -
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•