1520088 - Sites' autoplay preference is overridden by global autoplay preference

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Alastor Wu [:alwu]]

STR.

1. go to about:preferences#privacy
2. Find the autoplay setting area
3. Click Exceptions and choose block for "https://alastor0325.github.io/"
4. Click Save Changes and go back to about:preferences#privacy
5. Uncheck the check box for Block websites from automatically playing media with sound
6. go to "https://alastor0325.github.io/htmltests/autoplay_tests/autoplay_test1.html"

Expected.
7. video should not be allowed to start, because we have added the site into the blacklist

Actual.
7. video starts playing automatically

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1520088 - part1 : let 'IsMediaElementAllowedToPlay()' only check media element's attributes

We would like to have different phases checking for autoplay, the first phase is to check media element itself, so we need to move other non-related checkings out from 'IsMediaElementAllowedToPlay()'.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1520088 - part2 : ensure logging result can always be executed.

Ensure we can always see the debug log for the autoplay result.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1520088 - part3 : implement different phases autoplay checking.

The autoplay checking for media element has 4 different phases,
1. check whether media element itself meets the autoplay condition
2. check whethr the site is in the autoplay whitelist
3. check global autoplay setting and check wether the site is in the autoplay blacklist.
4. check whether media is allowed under current blocking model (click-to-play or user-gesture-activation)

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1520088 - part4 : modify test.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1520088 - part5 - add pref to control whether blacklist can override the default setting.

Comment 7

[Alastor Wu [:alwu]]

Try result looks good. https://treeherder.mozilla.org/#/jobs?repo=try&revision=94bfc9c3a12475b87d1c78df140418877aaf403b&selectedJob=222268491

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb086e6c019f
part1 : let 'IsMediaElementAllowedToPlay()' only check media element's attributes r=cpearce
https://hg.mozilla.org/integration/autoland/rev/1d2fcf021b32
part2 : ensure logging result can always be executed. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/2ce9b482cda2
part3 : implement different phases autoplay checking. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/5e0eb1c00744
part4 : modify test. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/5a384547b8b3
part5 - add pref to control whether blacklist can override the default setting. r=cpearce

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/eb086e6c019f
https://hg.mozilla.org/mozilla-central/rev/1d2fcf021b32
https://hg.mozilla.org/mozilla-central/rev/2ce9b482cda2
https://hg.mozilla.org/mozilla-central/rev/5e0eb1c00744
https://hg.mozilla.org/mozilla-central/rev/5a384547b8b3

Comment 10

[Rares Doghi, Desktop QA]

Hi, This issue no longer occurs in the latest nightly build, the Exceptions functionality works even with the feature turned off, I will mark this issue accordingly.
This issue was verified in the latest Nightly Build:
https://tools.taskcluster.net/index/gecko.v2.mozilla-central.latest.firefox